Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_1_X] fixed LHCInfo PopCon ignoring endTime parameter #42208

Conversation

JanChyczynski
Copy link
Contributor

PR description:

Backport of #42207

Fixed LHCInfo PopCon (LHCInfoPopConSourceHandler) ignoring the parameter endTime which is the end of the period it should perform the o2o for.

PR validation:

See master PR for validation description

Backport

Backport of #42207

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2023

A new Pull Request was created by @JanChyczynski (jan_chyczynski) for CMSSW_13_1_X.

It involves the following packages:

  • CondTools/RunInfo (db)

@perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor

type bug-fix

@tvami
Copy link
Contributor

tvami commented Jul 6, 2023

@cmsbuild, please test

@francescobrivio
Copy link
Contributor

backport of #42207

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b7320e/33582/summary.html
COMMIT: 5964dd6
CMSSW: CMSSW_13_1_X_2023-07-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42208/33582/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 8 lines from the logs
  • Reco comparison results: 193 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3222791
  • DQMHistoTests: Total failures: 5093
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3217676
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

+1

  • verbatim backport
  • tests clean

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Jul 8, 2023

+1

@cmsbuild cmsbuild merged commit 8c2e11d into cms-sw:CMSSW_13_1_X Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants