Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed LHCInfo PopCon ignoring endTime parameter #42207

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

JanChyczynski
Copy link
Contributor

PR description:

Fixed LHCInfo PopCon (LHCInfoPopConSourceHandler) ignoring the parameter endTime which is the end of the period it should perform the o2o for.

This parameter is not used in production in o2o jobs but it's useful for testing and regenerating payloads.

PR validation:

Validated by:

  1. running the PopCon scripts (LHCInfoPopConAnalyzerEndFill.py and LHCInfoPopConAnalyzerStartFill.py) with different parameters of startTime and endTime (including leaving the endTime empty, as it runs in production).
  2. validating if the correct fills were processed by checking the logs produced by the aforementioned Python scripts

Backport

It's going to be backported to CMSSW_13_1_X and CMSSW_13_0_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42207/36214

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2023

A new Pull Request was created by @JanChyczynski (jan_chyczynski) for master.

It involves the following packages:

  • CondTools/RunInfo (db)

@perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor

type bug-fix

@tvami
Copy link
Contributor

tvami commented Jul 6, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-87ac8e/33584/summary.html
COMMIT: 6c9a9e3
CMSSW: CMSSW_13_2_X_2023-07-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42207/33584/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 12 lines to the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3193892
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3193867
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

+1

  • PR according to description
  • tests ok

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Jul 7, 2023

+1

@cmsbuild cmsbuild merged commit 93924d0 into cms-sw:master Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants