-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed LHCInfo PopCon ignoring endTime parameter #42207
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42207/36214
|
A new Pull Request was created by @JanChyczynski (jan_chyczynski) for master. It involves the following packages:
@perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type bug-fix |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-87ac8e/33584/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Fixed
LHCInfo
PopCon (LHCInfoPopConSourceHandler
) ignoring the parameterendTime
which is the end of the period it should perform the o2o for.This parameter is not used in production in o2o jobs but it's useful for testing and regenerating payloads.
PR validation:
Validated by:
LHCInfoPopConAnalyzerEndFill.py
andLHCInfoPopConAnalyzerStartFill.py
) with different parameters ofstartTime
andendTime
(including leaving theendTime
empty, as it runs in production).Backport
It's going to be backported to CMSSW_13_1_X and CMSSW_13_0_X