Introduce missing hits recovery in the SiStripHitEfficiency PCL workflow to be in synch with CalibTree based one

[mmusich]

PR description:

This is a follow-up to PR #41970.
The goal of this PR is to extend the recovery of missing hits for the mkFit trajectories to the DQM-based SiStripHitEfficiency workflow (without this, the hit efficiency is overestimated in single-sided layers).

PR validation:

Run the following command:

cmsDriver.py stepReAlCa -s ALCA:PromptCalibProdSiStripHitEff --conditions 130X_dataRun3_Express_v2 --scenario pp --data --era Run3 --datatier ALCARECO --eventcontent ALCARECO --processName=ReAlCa -n 100000 --dasquery='file dataset=/StreamExpress/Run2023C-SiStripCalMinBias-Express-v4/ALCARECO run=368724' --nThreads=4

followed by:

cmsDriver.py stepHarvest -s ALCAHARVEST:SiStripHitEff --conditions 130X_dataRun3_Express_v2 --scenario pp --data --era Run3 --filein file:PromptCalibProdSiStripHitEff.root -n -1

and obtained the plot:

(as expected the efficiency for the DS layers gets reduced).

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will be backported together with #41970 .

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42175/36173

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CalibTracker/SiStripHitEfficiency (alca)
• Calibration/TkAlCaRecoProducers (alca)

@perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@echabert, @robervalwalsh, @gbenelli, @tocheng, @mmusich, @threus this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

test parameters:

• workflows = 1001.2, 1001.3

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-411a8b/33520/summary.html
COMMIT: c0ec2d5
CMSSW: CMSSW_13_2_X_2023-07-03-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42175/33520/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 8 lines from the logs
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3208767
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3208742
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 218 log files, 161 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42175/36188

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #42175 was updated. @perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-411a8b/33547/summary.html
COMMIT: a30235c
CMSSW: CMSSW_13_2_X_2023-07-04-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42175/33547/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 1001.31001.3_RunSingleMuon2022B/step2_RunSingleMuon2022B.log

[mmusich]

-1

Failure is also in IBs, see also #42185

[francescobrivio]

+1

• failure in tests is unrelated to this PR, see Introduce missing hits recovery in the SiStripHitEfficiency PCL workflow to be in synch with CalibTree based one #42175 (comment)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Failure in wf 1001.3 is unrelated

[perrotta]

merge