Recovery of missing hits for Strip Hit Efficiency

[DenkMybu]

PR description:

These changes implement the recovery of missing hits for the mkFit trajectories. Without this, the hit efficiency is overestimated in single-sided layers.

Output changes : no changes in the output format
Other PRs : None
Indico page for results : https://indico.cern.ch/event/1271487/ (Update on hit efficiency)

PR validation:

Version comparisons checked (see indico page above), tested with/without changes

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41970/35932

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @DenkMybu (Raphael Haeberle) for master.

It involves the following packages:

• CalibTracker/SiStripHitEfficiency (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@echabert, @mmusich, @robervalwalsh, @gbenelli, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[slava77]

The May 23 slides have

1. Sub-detector only
2. Adding sub-detector transitions

this is the latter, with transitions, right?

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a4735/33173/summary.html
COMMIT: 825ef90
CMSSW: CMSSW_13_2_X_2023-06-14-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41970/33173/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 11 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3196062
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3196040
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41970/35940

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #41970 was updated. @cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please check and sign again.

[tvami]

Comments on magic numbers and for loops + other cosmetic comments

[tvami]

in general the LogInfo and LogDebug dont need the << endl for the ending

[mmusich]

finally, please address also this comment @DenkMybu

Suggested change

	LogDebug("SiStripHitEfficiency:HitEff") << " hit actually being added to TM vector" << endl;
	LogDebug("SiStripHitEfficiency:HitEff") << " hit actually being added to TM vector";

[perrotta]

This comment still needs to be addressed

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41970/36057

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #41970 was updated. @cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a4735/33377/summary.html
COMMIT: c8dcc34
CMSSW: CMSSW_13_2_X_2023-06-25-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41970/33377/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 11 lines to the logs
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3200270
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3200245
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mmusich]

I tried to compare the hit efficiency:

• using vanilla code
• using the modifications in 8ddc8a3
• using the modifications in 8ddc8a3 + c8dcc34

and it looks like the latter two deliver the exact same effciency:

is it expected?

[perrotta]

is it expected?

I think so. Even if it is a bit counterintuitive to me, and certainly error prone, "-2" as uint is 4294967294 , but I've checked now that int(4294967294) = -2 (as it takes also into account the sign bit).
Therefore, my worries about differences of unsigned integers were probably not correct, at least for the code in this PR. Still, I'd fill a bit unconfortable in trusting in differences between unsigned integers, and the updates applied after the last commit clarify thinngs a bit, I guess.

[mmusich]

@perrotta

I think so. Even if it is a bit counterintuitive to me, and certainly error prone, "-2" as uint is 4294967294 , but I've checked now that int(4294967294) = -2 (as it takes also into account the sign bit).

thank you for the check.

@cms-sw/alca-l2 please sign at earliest convenience, as already reported, this needs to be backported (and integrated in the PCL as well).

[francescobrivio]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1