Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.1.X] Tracker Alignment: all in one Zmumu fixes #41911

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 9, 2023

backport of #41849

PR description:

Several fixes for the Zmumu validation tool, including:

  • python2 to python3 (unicode strings)
  • wrong name for a directory in a rootfile
  • wrong name in legend

PR validation:

  • Compiled with scram b
  • Ran tests with scram runtests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Intermediate verbatim backport of #41849 to 13.1.X for convenience of analyzing 2023 data

…fault

Fixed name of directory in Zmumu.root input file

Use titles from config instead of global tag name for the legend

Produce also PNG images in Zmumu merge
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_1_X.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jun 9, 2023

please test

@tvami
Copy link
Contributor

tvami commented Jun 9, 2023

+alca

  • unit test already passed

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73cb7c/33066/summary.html
COMMIT: 312ba75
CMSSW: CMSSW_13_1_X_2023-06-09-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41911/33066/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 13 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3221591
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3221569
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 67fd0a5 into cms-sw:CMSSW_13_1_X Jun 9, 2023
@mmusich mmusich deleted the AllInOne_ZmumuFixes_13_1_X branch June 9, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants