-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracker Alignment: all in one Zmumu fixes #41849
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41849/35751
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41849/35752
|
A new Pull Request was created by @amecca for master. It involves the following packages:
@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00e660/32949/summary.html Comparison SummarySummary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@amecca can you please add "Tracker Alignment" in the PR title? and please squash the commits, you have 5 commits changing 2 files. Thanks! |
…fault Fixed name of directory in Zmumu.root input file Use titles from config instead of global tag name for the legend Produce also PNG images in Zmumu merge
1179e41
to
fa1cf85
Compare
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41849/35784
|
Pull request #41849 was updated. @tvami, @saumyaphor4252, @francescobrivio can you please check and sign again. |
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00e660/32987/summary.html Comparison SummarySummary:
|
+1 |
PR description:
Several fixes for the Zmumu validation tool, including:
PR validation:
scram b
scram runtests
runTheMatrix.py -l limited -i all --ibeos