Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker Alignment: all in one Zmumu fixes #41849

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

amecca
Copy link
Contributor

@amecca amecca commented Jun 2, 2023

PR description:

Several fixes for the Zmumu validation tool, including:

  • python2 to python3 (unicode strings)
  • wrong name for a directory in a rootfile
  • wrong name in legend

PR validation:

  • Compiled with scram b
  • Ran tests with scram runtests
  • Ran tests with runTheMatrix.py -l limited -i all --ibeos

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2023

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41849/35751

  • This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41849/35752

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2023

A new Pull Request was created by @amecca for master.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Jun 2, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00e660/32949/summary.html
COMMIT: 1179e41
CMSSW: CMSSW_13_2_X_2023-06-01-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41849/32949/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 9 lines to the logs
  • Reco comparison results: 47 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3221457
  • DQMHistoTests: Total failures: 2225
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3219210
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@tvami
Copy link
Contributor

tvami commented Jun 2, 2023

@amecca can you please add "Tracker Alignment" in the PR title? and please squash the commits, you have 5 commits changing 2 files. Thanks!

…fault

Fixed name of directory in Zmumu.root input file

Use titles from config instead of global tag name for the legend

Produce also PNG images in Zmumu merge
@amecca amecca force-pushed the AllInOne_ZmumuFixes branch from 1179e41 to fa1cf85 Compare June 5, 2023 13:07
@amecca
Copy link
Contributor Author

amecca commented Jun 5, 2023

@amecca can you please add "Tracker Alignment" in the PR title? and please squash the commits, you have 5 commits changing 2 files. Thanks!

Hi @tvami,
I see that the title was already changed by Andrea.
I have squashed the commits into a single one.

@perrotta
Copy link
Contributor

perrotta commented Jun 5, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41849/35784

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2023

Pull request #41849 was updated. @tvami, @saumyaphor4252, @francescobrivio can you please check and sign again.

@tvami
Copy link
Contributor

tvami commented Jun 5, 2023

+alca

  • relevant unit tests already passed

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00e660/32987/summary.html
COMMIT: fa1cf85
CMSSW: CMSSW_13_2_X_2023-06-05-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41849/32987/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 23 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3219909
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3219884
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Jun 5, 2023

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants