Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HLT menu for D98 and D99 from Fake to RelVal2026 #41890

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Jun 7, 2023

PR description:

As title said, this PR updates the HLT menu of D98 and D99 workflows from Fake to RelVal2026.

PR validation:

Run D98, D99 workflows.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No need of backport.

@srimanob
Copy link
Contributor Author

srimanob commented Jun 7, 2023

test parameters:

  • workflows = 24834.0,25234.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41890/35831

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2023

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

srimanob commented Jun 7, 2023

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b9121/33031/summary.html
COMMIT: 8ab0085
CMSSW: CMSSW_13_2_X_2023-06-07-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41890/33031/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 15 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 61 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3408765
  • DQMHistoTests: Total failures: 2225
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3406518
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 217 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 2 / 48 workflows

@srimanob
Copy link
Contributor Author

srimanob commented Jun 7, 2023

+Upgrade

Fail comparison comes from mkfit workflow 12434.7 which does not relate to this PR. There is no change expected from Phase-2 workflows as no DQM yet for Phase-2 HLT.

@srimanob
Copy link
Contributor Author

srimanob commented Jun 9, 2023

Kindly ping @cms-sw/pdmv-l2

@kskovpen
Copy link
Contributor

kskovpen commented Jun 9, 2023

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Jun 9, 2023

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants