Fix logical error in the check of mask flag bits [13_1_X]

[abhih1]

PR description:

1. This PR fixes a bug in the ECAL DQM code which affected the check of status flag bits set on each channel.
   For eg in EnergyTask.cc here and here all other flag bits except kGood and kPoorCalib are being checked when the mask is bitwise inverted, but this is not what was intended.
   The intended behaviour is to check whether kGood or kPoorCalib is set, if not then ignore that channel.
   Similar changes are made in other affected files OccupancyTask.cc and TimingTask.cc

2. Another small fix is made to change the PU condition in MLClient.cc to ignore the PU=0 runs for the ML inference.

PR validation:

This was validated by running the online DQM workflow and testing the plots on a test DQM GUI.
Also validated by running the runtheMatrix workflow 136.874

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport to 13_1_X, which is next in production.
Master PR is : #41830

[cmsbuild]

A new Pull Request was created by @abhih1 (Abhirami Harilal) for CMSSW_13_1_X.

It involves the following packages:

• DQM/EcalMonitorClient (dqm)
• DQM/EcalMonitorTasks (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @argiro, @thomreis, @wang0jin this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix logical error in the check of mask flag bits  #41830

[emanueleusai]

type ecal

[emanueleusai]

backport of #41830

[emanueleusai]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4ea9c/32909/summary.html
COMMIT: 4a93e2d
CMSSW: CMSSW_13_1_X_2023-05-31-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41831/32909/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 21034.11421034.114_TTbar_14TeV+2026D88PU_OTInefficiency10PC/step2_TTbar_14TeV+2026D88PU_OTInefficiency10PC.log

Comparison Summary

Summary:

• You potentially removed 17 lines from the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3221591
• DQMHistoTests: Total failures: 1211
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3220358
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[abhih1]

The test failure seems unrelated to the PR.

[emanueleusai]

+1

• unrelated failures

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[perrotta]

merge