-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logical error in the check of mask flag bits #41830
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41830/35724
|
A new Pull Request was created by @abhih1 (Abhirami Harilal) for master. It involves the following packages:
@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type ecal |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a62684/32907/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR fixes a bug in the ECAL DQM code which affected the check of status flag bits set on each channel.
For eg in EnergyTask.cc here and here all other flag bits except kGood and kPoorCalib are being checked when the mask is bitwise inverted, but this is not what was intended.
The intended behaviour is to check whether kGood or kPoorCalib is set, if not then ignore that channel.
Similar changes are made in other affected files OccupancyTask.cc and TimingTask.cc
Another small fix is made to change the PU condition in MLClient.cc to ignore the PU=0 runs for the ML inference.
PR validation:
This was validated by running the online DQM workflow and testing the plots on a test DQM GUI.
Also validated by running the runtheMatrix workflow 136.874
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This is the Master PR. Backports are made to 13_1_X #41831 and 13_0_X #41832