[13.1.X] Modernize TrackSplittingMonitor and fix bug with filling ME-s

[mmusich]

backport of #41690

PR description:

The main goal of this PR is to fix the filling of the residuals in the TrackSplittingMonitor DQM code. I noticed that in recent cosmic data these plots are almost all empty (see e.g.https://tinyurl.com/2q9tgomk). This was caused by a bug in the filling of the MonitorElements which is fixed in this PR.
I profit of it to:

• modernize the code of the module
• introduce a fillDescriptions method and use it in the related configurations
• remove the TrackSplitMonitor from the Tracking DQM collisions setup as anyway there are no right input tracks to be fed to the module.

PR validation:

Run successfully runTheMatrix.py -l 138.1 -t 4 -j 8 --custom_command='-n 5000' --ibeos and checked that the cosmic plots are all filled.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #41690 needed for 2023 data-taking.

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_1_X.

It involves the following packages:

• DQM/TrackingMonitor (dqm)
• DQM/TrackingMonitorSource (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @VourMa, @hdelanno, @sroychow, @JanFSchulte, @VinInn, @fioriNTU, @jandrea, @mtosi, @idebruyn, @mmusich, @threus this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Modernize TrackSplittingMonitor and fix bug with filling ME-s #41690

[mmusich]

type bug-fix

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f83d7/32727/summary.html
COMMIT: 8f8abe8
CMSSW: CMSSW_13_1_X_2023-05-19-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41739/32727/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 7 lines from the logs
• Reco comparison results: 19 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3221654
• DQMHistoTests: Total failures: 112
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3221520
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -356.0 KiB( 47 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): -11.125 KiB Tracking/TrackParameters
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mmusich]

ping @cms-sw/dqm-l2

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mmusich]

@cmsbuild, please test

[cmsbuild]

Pull request #41739 was updated. @nothingface0, @emanueleusai, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f83d7/32779/summary.html
COMMIT: db4049f
CMSSW: CMSSW_13_1_X_2023-05-24-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41739/32779/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3221243
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3221215
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -356.0 KiB( 47 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): -11.125 KiB Tracking/TrackParameters
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1