Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NanoAOD] Backport of #41687 (Fix typo of imported ParticleNet tagger list for AK4 Puppi jets) to 13_1_X #41732

Merged

Conversation

nurfikri89
Copy link
Contributor

Backport of #41687

Original PR description:

This PR fixes a typo bug for the imported ParticleNet tagger list in nanoAOD_addDeepInfoAK4 function in jetsAK4_Puppi_cff.py. Confirmed by @scooperstein that this is a typo. Replace CHS with Puppi.

PR validation:

passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos

@cmsbuild
Copy link
Contributor

cmsbuild commented May 19, 2023

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for CMSSW_13_1_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @simonepigazzini, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

type bug-fix

@perrotta
Copy link
Contributor

@cms-sw/xpog-l2 , as this in a bug-fix, perhaps you would like to have it merged in the next CMSSW_13_1_0 release...

@simonepigazzini
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9fb474/32749/summary.html
COMMIT: 36c2dc7
CMSSW: CMSSW_13_1_X_2023-05-22-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41732/32749/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3222011
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3221983
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild cmsbuild merged commit 5f439c1 into cms-sw:CMSSW_13_1_X May 22, 2023
@nurfikri89 nurfikri89 deleted the portFrom132XTo131X_fixPNetPuppiNano branch May 23, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants