Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NanoAOD] Fix typo of imported ParticleNet tagger list for AK4 Puppi jets #41687

Merged

Conversation

nurfikri89
Copy link
Contributor

PR description:

This PR fixes a typo bug for the imported ParticleNet tagger list in nanoAOD_addDeepInfoAK4 function in jetsAK4_Puppi_cff.py. Confirmed by @scooperstein that this is a typo. Replace CHS with Puppi.

PR validation:

passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos

Backport:

To be backported to 13_1_X and 13_0_X.

@nurfikri89
Copy link
Contributor Author

FYI @vlimant @simonepigazzini @AnnikaStein @AlexDeMoor

@simonepigazzini
Copy link
Contributor

Does this affect the PNet output when running the evaluation on top of MINI or also when producing MINI collections? I.e. do we have a problem for prompt MINI/NANO or does this affect only workflows that re-evaluate PNet on top of MINI?

@scooperstein
Copy link

Does this affect the PNet output when running the evaluation on top of MINI or also when producing MINI collections? I.e. do we have a problem for prompt MINI/NANO or does this affect only workflows that re-evaluate PNet on top of MINI?

Hi @simonepigazzini , this only affects the evaluation of PNet at NanoAOD level on PUPPI jets. We missed this before because did not specifically test this workflow, since I think the only near-term evaluation of PNet at NanoAOD level planned was for the re-nano of the Run-2 UL with CHS jets. So it should anyway be transparent to any ongoing MINIAOD+NanoAOD workflows (this function was set not to be run under any current configuration), but it's important to fix it for later.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41687/35557

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @simonepigazzini, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@simonepigazzini
Copy link
Contributor

simonepigazzini commented May 15, 2023

Thanks @scooperstein, this is what I expected and it is good to hear. We should probably consider adding a test workflow in the matrix for this.

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb9fbb/32649/summary.html
COMMIT: 9c0a3f9
CMSSW: CMSSW_13_2_X_2023-05-15-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41687/32649/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 10 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3461474
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3461449
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

type bug-fix

@simonepigazzini
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 58880be into cms-sw:master May 19, 2023
@nurfikri89 nurfikri89 deleted the from132X_202305151100_fixPNetPuppiNano branch May 19, 2023 09:12
cmsbuild added a commit that referenced this pull request May 22, 2023
…uppiNano

[NanoAOD] Backport of #41687 (Fix typo of imported ParticleNet tagger list for AK4 Puppi jets) to 13_1_X
cmsbuild added a commit that referenced this pull request May 22, 2023
…uppiNano

[NanoAOD] Backport of #41687 (Fix typo of imported ParticleNet tagger list for AK4 Puppi jets) to 13_0_X
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants