-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NanoAOD] Fix typo of imported ParticleNet tagger list for AK4 Puppi jets #41687
[NanoAOD] Fix typo of imported ParticleNet tagger list for AK4 Puppi jets #41687
Conversation
Does this affect the PNet output when running the evaluation on top of MINI or also when producing MINI collections? I.e. do we have a problem for prompt MINI/NANO or does this affect only workflows that re-evaluate PNet on top of MINI? |
Hi @simonepigazzini , this only affects the evaluation of PNet at NanoAOD level on PUPPI jets. We missed this before because did not specifically test this workflow, since I think the only near-term evaluation of PNet at NanoAOD level planned was for the re-nano of the Run-2 UL with CHS jets. So it should anyway be transparent to any ongoing MINIAOD+NanoAOD workflows (this function was set not to be run under any current configuration), but it's important to fix it for later. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41687/35557
|
A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for master. It involves the following packages:
@cmsbuild, @simonepigazzini, @swertz, @vlimant can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Thanks @scooperstein, this is what I expected and it is good to hear. We should probably consider adding a test workflow in the matrix for this. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb9fbb/32649/summary.html Comparison SummarySummary:
|
type bug-fix |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
…uppiNano [NanoAOD] Backport of #41687 (Fix typo of imported ParticleNet tagger list for AK4 Puppi jets) to 13_1_X
…uppiNano [NanoAOD] Backport of #41687 (Fix typo of imported ParticleNet tagger list for AK4 Puppi jets) to 13_0_X
PR description:
This PR fixes a typo bug for the imported ParticleNet tagger list in
nanoAOD_addDeepInfoAK4
function injetsAK4_Puppi_cff.py
. Confirmed by @scooperstein that this is a typo. ReplaceCHS
withPuppi
.PR validation:
passes the usual runTheMatrix test:
runTheMatrix.py -l limited -i all --ibeos
Backport:
To be backported to
13_1_X
and13_0_X
.