Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce generic class to display TH2Poly-based tracker maps of values of selected template header parameters #41705

Merged
merged 4 commits into from
May 20, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 17, 2023

PR description:

With the revamping of the qScale parameter for pixel charge re-weighting (see #41623) it becomes important to be able to monitor the content of the SiPixelTemplates in terms of this parameter. I provide here a generic heavily-templated class SiPixelTemplateHeaderInfo that can print into a TH2Poly-based tracker map the values of selected template header parameters, and a concrete implementation for the qScale and Vbias as these seem the most interesting for the time being. More plots can be added as deemed needed.

PR validation:

Relies on the augmented unit tests. Also run privately:

getPayloadData.py \
    --plugin pluginSiPixelTemplateDBObject_PayloadInspector \
    --plot plot_SiPixelTemplateQScaleBPixMap \
    --tag SiPixelTemplateDBObject38Tv3_express \
    --time_type Run \
    --iovs '{"start_iov": "326083", "end_iov": "326083"}' \
    --db Prod \
    --test ;

and obtained the following plot:

image

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41705/35584

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CondCore/SiPixelPlugins (db)
  • DQM/TrackerRemapper (dqm)

@nothingface0, @emanueleusai, @tvami, @cmsbuild, @saumyaphor4252, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @francescobrivio, @rvenditti can you please review it and eventually sign? Thanks.
@hdelanno, @VinInn, @mroguljic, @dkotlins, @fioriNTU, @jandrea, @ferencek, @idebruyn, @mmusich, @threus, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented May 17, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e47a1/32690/summary.html
COMMIT: 92d7d76
CMSSW: CMSSW_13_2_X_2023-05-17-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41705/32690/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41705/35585

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #41705 was updated. @nothingface0, @emanueleusai, @tvami, @cmsbuild, @saumyaphor4252, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @francescobrivio, @rvenditti can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented May 17, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e47a1/32691/summary.html
COMMIT: 3a0c219
CMSSW: CMSSW_13_2_X_2023-05-17-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41705/32691/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
546.0 step 2
547.0 step 3
548.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially removed 21 lines from the logs
  • Reco comparison results: 61 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3222854
  • DQMHistoTests: Total failures: 2282
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3220550
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented May 17, 2023

+1

  • unit test passed

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 633d3a9 into cms-sw:master May 20, 2023
@mmusich mmusich deleted the qScalePI branch May 20, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants