[ROOT6] Updated root to tip of branch master

[aandvalenzuela]

No description provided.

[aandvalenzuela]

please test

[cmsbuild]

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch IB/CMSSW_13_2_X/rootmaster.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02c3a2/32660/summary.html
COMMIT: 018e511
CMSSW: CMSSW_13_2_ROOT6_X_2023-05-15-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8505/32660/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_ROOT6_X_2023-05-15-2300/src/PhysicsTools/TagAndProbe/src/TPTreeFiller.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_ROOT6_X_2023-05-15-2300/src/PhysicsTools/TagAndProbe/src/TagProbeFitter.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_ROOT6_X_2023-05-15-2300/src/PhysicsTools/TagAndProbe/src/TagProbePairMaker.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_ROOT6_X_2023-05-15-2300/src/PhysicsTools/TagAndProbe/src/ZGeneratorLineShape.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_ROOT6_X_2023-05-15-2300/src/PhysicsTools/TagAndProbe/src/TagProbeFitter.cc: In member function 'std::string TagProbeFitter::calculateEfficiency(std::string, const std::vector >&, const std::vector >&, std::vector >&, std::map, std::vector >&, std::map, std::vector > >&, std::vector >&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_ROOT6_X_2023-05-15-2300/src/PhysicsTools/TagAndProbe/src/TagProbeFitter.cc:343:29: error: invalid use of incomplete type 'class RooCatType'
  343 |     allCatValues.push_back(t->getVal());
      |                             ^~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/lcg/root/6.29.01-81071482742f2c67baf88011b270b558/include/RooAbsData.h:20,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/lcg/root/6.29.01-81071482742f2c67baf88011b270b558/include/RooDataSet.h:26,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_ROOT6_X_2023-05-15-2300/src/PhysicsTools/TagAndProbe/interface/TagProbeFitter.h:9,


[aandvalenzuela]

Could this be cause by the removal of RooCatType at root-project/root#12800?

[iarspider]

yes

[aandvalenzuela]

Thanks! I am working on a fix for this

[aandvalenzuela]

please test with cms-sw/cmssw#41737

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02c3a2/32732/summary.html
COMMIT: 018e511
CMSSW: CMSSW_13_2_ROOT6_X_2023-05-19-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8505/32732/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @mmusich Introduce generic class to display TH2Poly-based tracker maps of values of selected template header parameters  cmssw#41705
• @francescobrivio Fix LumiCache in AlcaBeamMonitor and OnlineBeamMonitor cmssw#41700
• @mascioti Adding Number of RecHits on Strip Stereo Modules cmssw#41725

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02c3a2/32732/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02c3a2/32732/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test testDataFormatsScoutingRun3 had ERRORS
---> test testDataFormatsScoutingRun2 had ERRORS

Comparison Summary

Summary:

• You potentially added 14 lines to the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3220460
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3220438
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 100.62399999999998 KiB( 47 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): 1.799 KiB SiStrip/IsolatedBunches
• DQMHistoSizes: changed ( 1000.0,... ): 1.705 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 1000.0,... ): -0.020 KiB AlcaBeamMonitor/Debug
• DQMHistoSizes: changed ( 1000.0,... ): -0.009 KiB AlcaBeamMonitor/Validation
• DQMHistoSizes: changed ( 12434.0,... ): 1.729 KiB HLT/SiStrip
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aandvalenzuela]

Tests testDataFormatsScoutingRunX are failing in IBs

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_2_X/rootmaster IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)