-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverting to AK4 CHS jets for DQM PNet monitoring #41694
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41694/35566
|
A new Pull Request was created by @marinakolosova (Marina Kolosova) for master. It involves the following packages:
@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test workflow 140.031 |
Thank you @marinakolosova ! |
type bug-fix |
Thanks @marinakolosova ! |
Hi, Just to add some further explanations here - the offline ParticleNet jet tagging for AK4 jets was updated recently (including regression+tau ID/reconstruction, on PUPPI jets) and backported to CMSSW_13_0_X #40745. The new network runs on miniAOD updates and cannot be run in the RECO step, whereas the previous version could be evaluated on either RECO or miniAOD inputs, and was trained on CHS jets. Since the DQM workflow is from the RECO/AOD as far as I understood, the new tagger is difficult to integrate. As a solution, we use the older offline tagger on CHS jets for the DQM - the b-tagging outputs should be highly correlated. Please hold off on integrating this PR until @marinakolosova has a chance to fully test this. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-614286/32668/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
Hi all, from our side everything looks ok, the PNet scores for AK4 CHS are being evaluated and the workflow is running as expected. No further update is needed for this PR, I will proceed with the backports. Thank you.
|
+1 |
This is a fix to PR 416555
Backports needed in:
CMSSW_13_1_X
CMSSW_13_0_X