Replaced AK8 and AK8 paths for ParticleNet DQMOffline monitoring for 2023 (master)

[marinakolosova]

PR description:

Modified the PNet monitoring for AK4 and AK8 jets:

• Replaced AK4 CHS jets with Puppi
• Renamed the paths to match the ones for 2023 (JIRA: CMSHLT-2695, CMSHLT-2759
• Added PNet monitoring in offlineHLTSourceOnAOD (PNet DQM not processed otherwise)

PR validation:

Went through the validation procedure described in HLTValidationAndDQM to produce the PNet DQM histograms.

The above changes will be backported to:
CMSSW_13_1_X
CMSSW_13_0_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41655/35535

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @marinakolosova (Marina Kolosova) for master.

It involves the following packages:

• DQMOffline/Trigger (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mtosi, @Fedespring, @missirol, @HuguesBrun, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-133bf9/32608/summary.html
COMMIT: 3a0c7e2
CMSSW: CMSSW_13_2_X_2023-05-14-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41655/32608/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 11 lines to the logs
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3461186
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3461158
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -119.23599999999999 KiB( 47 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): -39.886 KiB HLT/HIG
• DQMHistoSizes: changed ( 12434.0,... ): 40.097 KiB HLT/HIG
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[perrotta]

@marinakolosova @cms-sw/dqm-l2

There is an error in the latest IB for wf 140.031, quite likely related to this PR, see https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc11/CMSSW_13_2_X_2023-05-15-1100/pyRelValMatrixLogs/run/140.031_RunMuonEG2022B/step3_RunMuonEG2022B.log#/

The log says:

%MSG
----- Begin Fatal Exception 15-May-2023 14:31:55 CEST-----------------------
An exception of category 'InvalidReference' occurred while
   [0] Processing  Event run: 355769 lumi: 64 event: 41848823 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Calling method for module ParticleNetJetTagMonitor/'particleNetAK4BTagMonitoring'
Exception Message:
AssociationVector: trying to use [] operator passing a reference
 with the wrong product id (i.e.: pointing to the wrong collection)
 keyRef.id = 5:3567, ref.id = 5:3565
----- End Fatal Exception -------------------------------------------------

Please have a look and provide a fix at your earliest

[marinakolosova]

Hi @perrotta,

As this is urgent I reverted to just renaming the paths. Shall I create a new PR?

Thank you,
Marina

[perrotta]

As this is urgent I reverted to just renaming the paths. Shall I create a new PR?

Thank you @marinakolosova
I think a correct fix should be implemented, I don't know whether "renaming the paths" can be such a correct fix.
"Urgent" does not mean that it has to be fixed within hours: if you can properly debug that workflow 140.031 and provide a proper fix in a day or two it is still fine. Then the fixed PR will get backported, if needed

[missirol]

This PR also causes failures to the HLT-Validation tests, e.g.
https://cmssdt.cern.ch/SDT/jenkins-artifacts/HLT-Validation/CMSSW_13_2_X_2023-05-15-1100/el8_amd64_gcc11/RelVal_RECO_GRun_MC.log

@marinakolosova , is the fix as easy as reverting the following change ? If so, please consider making a PR for this.

https://github.com/cms-sw/cmssw/pull/41655/files#diff-ab1d07150b4d2c934a69b4db5f99930aeb2b4dc47dbff534e48059ea7285dab5R138

[marinakolosova]

Hi @missirol @perrotta, a fix is provided here PR41694