Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run3 data GTs #41609

Merged
merged 1 commit into from
May 11, 2023
Merged

Conversation

francescobrivio
Copy link
Contributor

PR description:

This PR updates the run3 data GTs:

GT differences:

PR validation:

Code compiles - will use the bot to run the matrix tests

Backport:

Not a backport, but backports to 13_1_X, 13_0_X and 12_4_X (for the offline GT only) will be provided soon

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41609/35501

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

test parameters:

  • workflow = 1002.3

@francescobrivio
Copy link
Contributor Author

test parameters:
*

@francescobrivio
Copy link
Contributor Author

test parameters:

@francescobrivio
Copy link
Contributor Author

@perrotta @rappoccio
PR #41597 is not really needed in order to merge this PR - I just added it to see the results now that the BSOnline tags are included in the Prompt GT (FYI @mmusich).
So the requires-external flag (which I know it's automatically added by the bot) isn't correct per se, just so you know when it's time to merge this PR.

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@mmusich
Copy link
Contributor

mmusich commented May 10, 2023

The logs for e.g. wf 138.4 are already available.
There's still a gazillion of L1T errors, but at least the BeamSpot warnings are gone!

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ecfef/32534/summary.html
COMMIT: 8626c55
CMSSW: CMSSW_13_2_X_2023-05-10-1200/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41609/32534/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 20 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3475710
  • DQMHistoTests: Total failures: 63
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3475625
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 160 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented May 10, 2023

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4b92533 into cms-sw:master May 11, 2023
@francescobrivio francescobrivio deleted the alca-update_data_run3_GTs branch June 9, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants