-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BeamSpotOnline tags to the Prompt GT #41459
Comments
assign alca,db |
New categories assigned: db,alca @francescobrivio,@francescobrivio,@saumyaphor4252,@saumyaphor4252,@tvami,@tvami you have been requested to review this Pull request/Issue and eventually sign? Thanks |
A new Issue was created by @francescobrivio . @Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
It's a bit counterintuitive to add HLT tags to the Prompt GT. Was this decided so there is no need for code changes (which I guess would be the more intuitive solution)? |
The need of adding the HLT tags originates from the need of monitoring in prompt the difference between the online and offline beamspots. |
Thanks Marco, indeed in the description I forgot to mention that this will restore the possibility to monitor in prompt the difference between online and PCL/offline. |
being tested in dmwm/T0#4817 |
This issue is ready to be signed (and closed).
|
This issue is fully signed and ready to be closed. |
Description
As reported in Issue#41456, the
BeamSpotFromDB
is one of the main offenders concerning the LogErrors and LogWarning emitted during Prompt reco.Solution
As nicely debugged by @mmusich in #41456 (comment), and after some private discussion, it was decided that the best way to fix this is to include the BeamSpotOnline tags (which are already present in the HLT/Express GTs) in the Prompt GT:
BeamSpotOnlineHLTObjectsRcd
BeamSpotOnlineLegacyObjectsRcd
FYI @gennai @dzuolo
The text was updated successfully, but these errors were encountered: