Address issues #41476
Address issues #41476
Conversation
|
type bugfix |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41476/35340
|
|
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master. It involves the following packages:
@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89f3a7/32269/summary.html Comparison SummarySummary:
|
|
test parameters:
|
|
@cmsbuild, please test |
cmsbuild
added
tests-pending
code-checks-pending
and removed
tests-approved
code-checks-approved
labels
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41476/35344
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41476/35345
|
|
Pull request #41476 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again. |
|
please test it seems there was a real problem in fill/access of arrays. This may change results, so we need to run standard set of tests first. |
|
The unit test failure (TestTriggerResultsFormat) is probably caused by the fact that the base IB release for this PR test invocation precedes the release where this unit test was added. The unit test depends on a new data file added to the new external data area. I think it will pick it up if you rerun the tests again. ASAN with CMSSW_13_1_X_2023-05-01-2300 should have it. |
|
@cmsbuild, please test |
|
It was a mistake to try to fix two issues in one PR. Let us test run but this will be closed and two new will be opened. Relatively simple fix #41487 is already submitted. Another will be proposed for DIGI step when 13_2_X will be available. |
|
-1 Failed Tests: RelVals RelValsThe relvals timed out after 4 hours. |
PR description:
Address two issues:
[ASAN] heap-buffer-overflow in EcalDetailedTimeRecHitProducer::produce() #40764 : bug in resize of a vector;
Clean-up of the code for R-hadron interaction with matter is needed #40477 : clean-up of the old model class for R-hadrons hadronic interactions, removed old commented lines, removed unused variables, substitute internal Poisson method by Geant4 function, simplified count of the number of nucleons, substitute exit(..) by G4Exception(..).
No change in any WF is expected.
PR validation:
private
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: the fix of G4TimeEcal will be backported to 13_0