Added extra Invalid = -1 enum to avoid llvm16 build errors

[smuzaffar]

I am trying to test LLVM 16.0.3 for CLANG IBs and there are few build [a] errors. Looks like llvm 16 does not like to set -1 for an enum. ThisPR proposes to add the extra Invalid = -1 enum value. Local tests with this change and llvm16 passed

[a]

CondFormats/L1TObjects/src/L1GtDefinitions.cc:53:78: error: integer value -1 is outside the valid range of values [0, 7] for this enumeration type [-Wenum-constexpr-conversion]
                                                                    {nullptr, (L1GtBoardType)-1}};
CondFormats/L1TObjects/src/L1GtDefinitions.cc:81:74: error: integer value -1 is outside the valid range of values [0, 31] for this enumeration type [-Wenum-constexpr-conversion]
                                                                {nullptr, (L1GtPsbQuad)-1}};

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41458/35321

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• CondFormats/L1TObjects (l1, db, alca)
• DataFormats/L1GlobalTrigger (l1)
• L1Trigger/L1TGlobal (l1)

@epalencia, @cmsbuild, @saumyaphor4252, @aloeliger, @francescobrivio, @cecilecaillol, @tvami can you please review it and eventually sign? Thanks.
@rovere, @Martin-Grunewald, @missirol, @tocheng, @mmusich, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e377f/32244/summary.html
COMMIT: 0ef2861
CMSSW: CMSSW_13_1_X_2023-04-28-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41458/32244/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 9 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3460877
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3460854
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[smuzaffar]

@cms-sw/l1-l2 @cms-sw/db-l2 , can you please review this. This would allow us to integrate llvm 16 in clang builds

[francescobrivio]

+db

• technical
• I believe the only failure in the tests is unrelated to this PR (it's in HLT/SiStrips)

[aloeliger]

+l1

• Adds option for testing against invalid boards, no substantial changes expected.

[tvami]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1