[13_1_X] Reverting BeamSpot Legacy DQM client error scale to 1p2

[dzuolo]

PR description:

This PR reverts the value of the error scale of the BeamSpot fit in the DQM Legacy client to 1.2
The error scale is a multiplicative term of the covariance matrix that accounts for under or over estimation of the PV errors.
The value 1.2 was estimated at the beginning of Run 1 operations and never changed since then.
At the beginning of the 2022 data taking at 13p6 TeV the client was constantly crashing due to fit failures. Offline investigations revealed that setting the error scale to 1.0 was curing the issue so we changed the value. Unfortunately we did not investigate the impact on the BeamSpot transverse widths. As you can see in the attachment we get a width of 18 um with error scale 1.2 which is quite far from the expected 10 um that we can get with an error scale of 1.2
We are in contact with Tracker DPG to perform an evaluation of the pixel vertices pulls using the split vertex method but we would to change the value in production before LHC moves to PHYSICS.

This change will affect the BeamSpot used in the HLT and Express reco and not the one in the Prompt reco.

PR validation:

See attached plots. The code itself is unchanged.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Forward port of #41446

FYI: @mmusich @francescobrivio @gennai - could one of you please launch the test? Thanks!

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41447/35307

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @dzuolo (Davide Zuolo) for master.

It involves the following packages:

• DQM/Integration (dqm)

@pmandrik, @emanueleusai, @micsucmed, @syuvivida, @rvenditti can you please review it and eventually sign? Thanks.
@battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac12d8/32203/summary.html
COMMIT: 4f14924
CMSSW: CMSSW_13_1_X_2023-04-27-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41447/32203/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 12 lines from the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3460685
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3460657
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[syuvivida]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1