[13_0_X] Reverting BeamSpot Legacy DQM client error scale to 1p2

[dzuolo]

PR description:

This PR reverts the value of the error scale of the BeamSpot fit in the DQM Legacy client to 1.2
The error scale is a multiplicative term of the covariance matrix that accounts for under or over estimation of the PV errors.
The value 1.2 was estimated at the beginning of Run 1 operations and never changed since then.
At the beginning of the 2022 data taking at 13p6 TeV the client was constantly crashing due to fit failures. Offline investigations revealed that setting the error scale to 1.0 was curing the issue so we changed the value. Unfortunately we did not investigate the impact on the BeamSpot transverse widths. As you can see in the attachment we get a width of 18 um with error scale 1.2 which is quite far from the expected 10 um that we can get with an error scale of 1.2
We are in contact with Tracker DPG to perform an evaluation of the pixel vertices pulls using the split vertex method but we would to change the value in production before LHC moves to PHYSICS.

These change will affect the BeamSpot used in the HLT and Express reco and not the one in the Prompt reco.

PR validation:

See attached plots. The code itself is unchanged.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport. A forward port to 13_1_X will be made soon.

FYI: @mmusich @francescobrivio @gennai - could one of you please launch the test? Thanks!

@cmsdqm : can you please put this PR in production before the next stable beams? Thanks!

[cmsbuild]

A new Pull Request was created by @dzuolo (Davide Zuolo) for CMSSW_13_0_X.

It involves the following packages:

• DQM/Integration (dqm)

@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from [13_1_X] Reverting BeamSpot Legacy DQM client error scale to 1p2 #41447

[mmusich]

please test

[francescobrivio]

@cms-sw/dqm-l2 can you test this PR online in P5?

[francescobrivio]

@dzuolo can you:

• update the title to make clear this is for the "BeamSpot Legacy DQM client"
• add "[13_0_X]" at the beginning of the title
• mention in the description that this affects the HLT/Express Beamspot, and not the Prompt one

and of course:

• prepare the 13_1_X PR :D

[francescobrivio]

backport of #41447

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac7048/32200/summary.html
COMMIT: 1b96ec3
CMSSW: CMSSW_13_0_X_2023-04-27-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41446/32200/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 5 lines to the logs
• Reco comparison results: 15 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3554298
• DQMHistoTests: Total failures: 10
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3554266
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[dzuolo]

Dear colleagues,
just to close the thread let me share here the pull measurements for the pixelVertices (thanks Marco for your help!).
As you can see we have 1.1 in X/Y and 1.3 in Z and this is the reason for using an error scale of 1.2.

pullZ_unbinned.pdf
pullY_unbinned.pdf
pullX_unbinned.pdf

[mmusich]

can you test this PR online in P5?

any news on this test? would be good to pick this up for the next fill.

[francescobrivio]

can you test this PR online in P5?

any news on this test? would be good to pick this up for the next fill.

Ciao Marco, AFAIU this has been put in production since this morning.
By looking at the first line of:
https://cmsweb.cern.ch/dqm/dqm-square/tmp/content_parser_productionPARSER_job0.log
I'd say it's online.

@cms-sw/dqm-l2 maybe you can review/sign this PR? and the master one?

[syuvivida]

+1
already deployed online

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1