-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 12450.*
wfs (2023, ZMuMu) from GPU RelVals
#41386
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41386/35252
|
A new Pull Request was created by @missirol (Marino Missiroli) for master. It involves the following packages:
@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
9e654ac
to
cfa4fa3
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41386/35253
|
Pull request #41386 was updated. @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please check and sign again. |
test parameters:
|
please test @cms-sw/orp-l2 , this PR 'fixes' the 6 failures in the |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-41accc/32090/summary.html Comparison SummarySummary:
GPU Comparison SummarySummary:
|
+1 |
The line that control processing string is It tries to look datasets with processing string Most of 12_5_0_pre4 were produced with For If GPU 12450.* wfs are needed anyways, I think we should not merge this PR, but @cms-sw/pdmv-l2 to submit ZMM using 12_5_0_pre4. You should get input for those workflows. It will take only few days, maybe we can keep the error for now, to avoid re-opening in the next few days. |
@srimanob totally agree that the preferred solution would be to have the adequate sample produced. Didn't intend to be hasty, I wanted to give way to @cms-sw/orp-l2 to choose if this is something we can live with for now or they prefer to a quick fix now (-: On a side note: I imagine #41225 is failing for the same reason, isn't it? |
@kskovpen @sunilUIET @bbilin , please review this PR (and see the question above for PdmV). |
I think we can go ahead without missing samples. In the meantime, we will also submit the required samples. |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
Do you have a time estimate for the production of the missing samples? Of course, the preferred option would be to have the tests running, and if it can be achieved in just a few days I'd rather avoid merging this PR |
@sunilUIET , please see the question above by ORP. Prompt feedback is appreciated, so #41371 could also move forward. |
https://dmytro.web.cern.ch/dmytro/cmsprodmon/requests.php?campaign=CMSSW_12_5_0_pre4__fullsim_noPU_2023_14TeV-1682483673 samples are done. I hope test should be fine now. Please let us know if something is missing |
Thanks @sunilUIET. Closing this PR. |
PR description:
#41354 added Run-3 wfs with 2023 conditions to the list of GPU RelVals.
After that PR was merged, the
12450.*
wfs failed in the relevant IB (i.e.CMSSW_13_1_GPU_X_2023-04-21-2300
), likely because the corresponding GEN-SIM input sample does not exist (see #41354 (comment)).This PR disables those GPU RelVals to avoid IB failures, until the situation is clarified.
PR validation:
None.
If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:
If accepted, this PR will be backported in #41371.