Modernize / optimize DisappearingMuonsSkimming

[mmusich]

PR description:

I noticed that the code introduced in #40666 could be optimized in a few places, mostly:

• do not use track matching in dR / dPt when direct comparison of track references is available
• use range-based loops
• modernize access to event collections
• avoid repeated calculations
• avoid code duplication
• use deltaR2 in lieu of deltaR

I propose these optimizations here, as well as a test configuration that I have been using to make sure the update code results in exactly the same output as the old one.

PR validation:

Run the Configuration/Skimming/test/test_DisMuon_cfg.py file introduced here in a vanilla CMSSW_13_1_X_2023-03-27-1100 release and in this branch and checked that the exact same events are selected.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41225/34941

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• Configuration/Skimming (pdmv)

@cmsbuild, @bbilin, @sunilUIET, @kskovpen can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos, @youyingli this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee9a20/31706/summary.html
COMMIT: 0504895
CMSSW: CMSSW_13_1_X_2023-03-30-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41225/31706/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 19 lines from the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3553709
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3553681
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41225/34986

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #41225 was updated. @cmsbuild, @bbilin, @sunilUIET, @kskovpen can you please check and sign again.

[mmusich]

please test

[mmusich]

type performance-improvement

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41225/35093

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #41225 was updated. @cmsbuild, @bbilin, @sunilUIET, @kskovpen can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee9a20/31872/summary.html
COMMIT: 7a3a15d
CMSSW: CMSSW_13_1_X_2023-04-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41225/31872/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 11 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3459609
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3459581
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mmusich]

@youyingli

thank you for the optimization. Could you please also make another PR to backport this PR to 13_0_X milestone for 2023 data taking?

sure, here it is: #41311.
Let me point out - though - that pdmv still didn't sign this one (after 5 days from the last trivial update).

[kskovpen]

+pdmv

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1