-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce cms python types in configurations #41361
Conversation
please test |
loosely associated with #41349 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41361/35208
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Failed Tests: UnitTests RelVals The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Unit TestsI found errors in the following unit tests: ---> test runtestPhysicsToolsPatAlgos had ERRORS RelVals
|
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41361/35224
|
Pull request #41361 was updated. @smuzaffar, @civanch, @Dr15Jones, @swertz, @vlimant, @makortel, @micsucmed, @emanueleusai, @mdhildreth, @clacaputo, @syuvivida, @simonepigazzini, @pmandrik, @mandrenguyen, @rvenditti can you please check and sign again. |
+1 |
+1 |
+1 |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR validation:
Framework unit tests pass.