Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce cms python types in configurations #41361

Merged
merged 7 commits into from
May 15, 2023

Conversation

Dr15Jones
Copy link
Contributor

PR description:

  • when assigning a parameter in python using an explicit type, require that existing value's type matches new type
  • fixed problem where _ProxyParameter was not forwarding container methods to set value

PR validation:

Framework unit tests pass.

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

loosely associated with #41349

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41361/35208

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • FWCore/ParameterSet (core)

@makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7082af/32007/summary.html
COMMIT: 19aab2b
CMSSW: CMSSW_13_1_X_2023-04-17-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41361/32007/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7082af/32007/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7082af/32007/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

RelVals

  • 101.0101.0_SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL.log

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41361/35224

@cmsbuild
Copy link
Contributor

Pull request #41361 was updated. @smuzaffar, @civanch, @Dr15Jones, @swertz, @vlimant, @makortel, @micsucmed, @emanueleusai, @mdhildreth, @clacaputo, @syuvivida, @simonepigazzini, @pmandrik, @mandrenguyen, @rvenditti can you please check and sign again.

@emanueleusai
Copy link
Member

+1

@makortel
Copy link
Contributor

+1

@mandrenguyen
Copy link
Contributor

+1
No change to reco

@civanch
Copy link
Contributor

civanch commented May 11, 2023

+1

@vlimant
Copy link
Contributor

vlimant commented May 15, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants