-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve configuration parameter type compatibility checks in python #41356
Comments
assign core |
New categories assigned: core @Dr15Jones,@smuzaffar,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks |
A new Issue was created by @makortel Matti Kortelainen. @Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
The improvements were done in #41361 |
+core |
This issue is fully signed and ready to be closed. |
This issue is a follow-up to discussion in #41349 (comment)
Currently assignment like
override the type of the existing parameter of a PSet. In most cases the incorrect type gets caught by the C++ code (in case of #32070 it wasn't caught, which is fixed in #41349). It would be generally beneficial to be able catch such inconsistencies already earlier in python.
For regular
cms.X
types @Dr15Jones came with three optionsoptional
,required
orallowed
enforce that the type is properdel pset.name
to get rid of itoverride
proxy type, making intentional type changes to look likep.a = cms.override.int32(4)
Since the PSet assignment is really handled by
PSet.__setattr__()
, the necessary changes would need to go there, more specifically tocmssw/FWCore/ParameterSet/python/Mixins.py
Lines 278 to 282 in 107dcfb
The text was updated successfully, but these errors were encountered: