Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_1_X]changing Era to Run3_2023 for 2023 WFs #41319

Merged
merged 3 commits into from
Apr 18, 2023
Merged

[13_1_X]changing Era to Run3_2023 for 2023 WFs #41319

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab8f78d
changing Era for Run3_2023 for 2023 WFs
sunilUIET Apr 11, 2023
e94bae2
add WFs with era Run3_2023
sunilUIET Apr 12, 2023
7db6caf
changing existing 2023 WFs to Era Run3_2023
sunilUIET Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2120,6 +2120,7 @@ def condition(self, fragment, stepList, key, hasHarvest):
offset = 0.303,
)


class UpgradeWorkflow_DD4hep(UpgradeWorkflow):
def setup_(self, step, stepName, stepDict, k, properties):
if 'Run3' in stepDict[step][k]['--era'] and 'Fast' not in stepDict[step][k]['--era']:
Expand Down Expand Up @@ -2185,7 +2186,7 @@ def condition(self, fragment, stepList, key, hasHarvest):

class UpgradeWorkflow_DDDDB(UpgradeWorkflow):
def setup_(self, step, stepName, stepDict, k, properties):
if 'Run3' in stepDict[step][k]['--era'] and 'Fast' not in stepDict[step][k]['--era']:
if 'Run3' in stepDict[step][k]['--era'] and '2023' not in stepDict[step][k]['--era'] and 'Fast' not in stepDict[step][k]['--era']:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Just to understand) What is the purpose of this modification?
Should we add 2024, 2025, etc. here in the coming years?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a temporary fix to not screw up on modification. The follow up PR should clean this thing out when we have a clear Era, and all necessary Era(s) are in place, i.e. DDD for 2023,4,5 or FastSim for 2023,4,5.

# retain any other eras
tmp_eras = stepDict[step][k]['--era'].split(',')
tmp_eras[tmp_eras.index("Run3")] = 'Run3_DDD'
Expand Down Expand Up @@ -2314,7 +2315,7 @@ def condition(self, fragment, stepList, key, hasHarvest):
'Geom' : 'DB:Extended',
'GT' : 'auto:phase1_2023_realistic',
'HLTmenu': '@relval2023',
'Era' : 'Run3',
'Era' : 'Run3_2023',
'BeamSpot': 'Realistic25ns13p6TeVEarly2022Collision',
'ScenToRun' : ['GenSim','Digi','RecoNano','HARVESTNano','ALCA'],
},
Expand Down