[13_1_X]changing Era to Run3_2023 for 2023 WFs #41319

sunilUIET · 2023-04-11T16:34:30Z

PR description:

This PR is to change era from "Run3" to "Run3_2023" for relval WFs defined for 2023 conditions. Era "Run3_2023" is first introduced in PR #41271 .

PR validation:

Need to be tested with PR #41271

sunilUIET · 2023-04-11T16:38:09Z

@cmsbuild please test with #41271

cmsbuild · 2023-04-11T16:41:39Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41319/35132

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Adding all geometries and the FullRecoGPU for Patatrack wfs for Phase2 #41011, Guard for No Digis for Phase2 and Patatrack NuGun #41255, Add run3 tracking low pu era #33532, Displaced regional tracking iteration #40643

cmsbuild · 2023-04-11T16:42:08Z

A new Pull Request was created by @sunilUIET (sunil bansal) for master.

It involves the following packages:

Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @srimanob, @sunilUIET, @kskovpen, @AdrianoDee can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

francescobrivio · 2023-04-11T16:45:54Z

Hi @sunilUIET thanks for this!
Just for my understanding: is there a plan to update also all the '--era':'Run3' occurrences in Configuration/PyReleaseValidation/python/relval_steps.py (and all the other release validation scripts)?

sunilUIET · 2023-04-11T17:05:35Z

Hi @sunilUIET thanks for this! Just for my understanding: is there a plan to update also all the '--era':'Run3' occurrences in Configuration/PyReleaseValidation/python/relval_steps.py (and all the other release validation scripts)?

Configuration/PyReleaseValidation/python/relval_steps.py

Hi @francescobrivio , I think we can change it for 2023 WFs only, for the time being, keeping the settings as it is for old WFs. As far as 2023 WFs are concerned, IIUC, it should be enough to change settings in https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py#L2364,L2370 and changes should be propagated to all steps.

sunilUIET · 2023-04-11T17:13:25Z

test parameters:

relvals_opt= -w upgrade
workflows = 12402.0

sunilUIET · 2023-04-11T17:13:53Z

@cmsbuild please test with #41271

cmsbuild · 2023-04-11T17:51:45Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba0374/31917/summary.html
COMMIT: ab8f78d
CMSSW: CMSSW_13_1_X_2023-04-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41319/31917/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 4.53, 4.22, 5.1, 7.3, 8, 9.0, 136.731, 136.7611, 136.8311, 136.88811, 136.793, 136.874, 138.4, 138.5, 139.001, 140.53, 140.56, 12434.0, 23696.0, 23700.0, 25, 1306.0, 23834.999, 158.01, 135.4, 10024.0, 1330, 13234.0, 312.0, 10042.0, 11834.0, 23234.0, 2500.601, 10824.0, 23634.0, 23634.911, 250202.181, 2018.1, 101.0, 1000, 1001, 10224.0, 25202.0, 11634.911, 11634.914, 11634.0, 11634.7, 13434.0
ValueError: Undefined workflows: 12402.0

RelVals-INPUT

sunilUIET · 2023-04-13T10:35:19Z

Hi @sunilUIET

You will need to update this line, https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py#L2239 by adding and '2023' not in stepDict[step][k]['--era'] This is to protect the wierd era modification. Then everything should work out-of box without the need for extra workflow.

Thanks @srimanob for the input to solve the issue.

cmsbuild · 2023-04-13T10:37:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41319/35159

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Adding all geometries and the FullRecoGPU for Patatrack wfs for Phase2 #41011, Guard for No Digis for Phase2 and Patatrack NuGun #41255, Add run3 tracking low pu era #33532, Displaced regional tracking iteration #40643

cmsbuild · 2023-04-13T10:37:36Z

Pull request #41319 was updated. @bbilin, @srimanob, @sunilUIET, @kskovpen, @AdrianoDee can you please check and sign again.

cmsbuild · 2023-04-13T13:36:44Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba0374/31964/summary.html
COMMIT: 7db6caf
CMSSW: CMSSW_13_1_X_2023-04-12-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41319/31964/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 2255 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3619444
DQMHistoTests: Total failures: 1173
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3618249
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 212 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

sunilUIET · 2023-04-13T13:52:25Z

+pdmv

srimanob · 2023-04-17T19:07:37Z

+Upgrade

cmsbuild · 2023-04-17T19:08:09Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-04-17T20:49:45Z

Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py

@@ -2185,7 +2186,7 @@ def condition(self, fragment, stepList, key, hasHarvest):

 class UpgradeWorkflow_DDDDB(UpgradeWorkflow):
    def setup_(self, step, stepName, stepDict, k, properties):
-        if 'Run3' in stepDict[step][k]['--era'] and 'Fast' not in stepDict[step][k]['--era']:
+        if 'Run3' in stepDict[step][k]['--era']  and '2023' not in stepDict[step][k]['--era'] and 'Fast' not in stepDict[step][k]['--era']:


(Just to understand) What is the purpose of this modification?
Should we add 2024, 2025, etc. here in the coming years?

This is just a temporary fix to not screw up on modification. The follow up PR should clean this thing out when we have a clear Era, and all necessary Era(s) are in place, i.e. DDD for 2023,4,5 or FastSim for 2023,4,5.

perrotta · 2023-04-18T13:05:07Z

+1

swagata87 · 2023-04-19T10:26:02Z

do we need a backport of this PR to 13_0_X?

FYI, #41368 this is backport of my PR

changing Era for Run3_2023 for 2023 WFs

ab8f78d

cmsbuild added this to the CMSSW_13_1_X milestone Apr 11, 2023

cmsbuild added pending-signatures tests-pending orp-pending pdmv-pending upgrade-pending code-checks-pending labels Apr 11, 2023

cmsbuild added tests-started requires-external and removed tests-pending labels Apr 11, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 11, 2023

cmsbuild added tests-rejected and removed tests-started labels Apr 11, 2023

swagata87 mentioned this pull request Apr 11, 2023

New Run3 era for updated HB thresholds in 2023 #41271

Merged

add WFs with era Run3_2023

e94bae2

cmsbuild added tests-pending code-checks-pending and removed tests-rejected requires-external code-checks-approved labels Apr 12, 2023

cmsbuild added tests-started requires-external and removed tests-pending labels Apr 13, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 13, 2023

cmsbuild added tests-approved and removed tests-started labels Apr 13, 2023

cmsbuild added pdmv-approved and removed pdmv-pending labels Apr 13, 2023

This was referenced Apr 14, 2023

Ecal CC timing reconstruction deployment 13 0 0 #41342

Closed

Pixel Alpaka Migration: AlpakaInterface Updates [II] #41284

Closed

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Apr 17, 2023

perrotta reviewed Apr 17, 2023

View reviewed changes

cmsbuild added orp-approved and removed orp-pending labels Apr 18, 2023

cmsbuild merged commit 28236a9 into cms-sw:master Apr 18, 2023

cmsbuild mentioned this pull request Apr 18, 2023

Rocm/Cuda unit test improvement cms-sw/cmssw-config#95

Merged

sunilUIET mentioned this pull request Apr 19, 2023

[13_0_X backport ]change era to Run3_2023 for 2023 WFs #41373

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[13_1_X]changing Era to Run3_2023 for 2023 WFs #41319

[13_1_X]changing Era to Run3_2023 for 2023 WFs #41319

sunilUIET commented Apr 11, 2023

sunilUIET commented Apr 11, 2023 •

edited

Loading

cmsbuild commented Apr 11, 2023

cmsbuild commented Apr 11, 2023

francescobrivio commented Apr 11, 2023

sunilUIET commented Apr 11, 2023

sunilUIET commented Apr 11, 2023

sunilUIET commented Apr 11, 2023

cmsbuild commented Apr 11, 2023

sunilUIET commented Apr 13, 2023

cmsbuild commented Apr 13, 2023

cmsbuild commented Apr 13, 2023

cmsbuild commented Apr 13, 2023

sunilUIET commented Apr 13, 2023

srimanob commented Apr 17, 2023

cmsbuild commented Apr 17, 2023

perrotta Apr 17, 2023

srimanob Apr 18, 2023

perrotta commented Apr 18, 2023

swagata87 commented Apr 19, 2023

[13_1_X]changing Era to Run3_2023 for 2023 WFs #41319

[13_1_X]changing Era to Run3_2023 for 2023 WFs #41319

Conversation

sunilUIET commented Apr 11, 2023

PR description:

PR validation:

sunilUIET commented Apr 11, 2023 • edited Loading

cmsbuild commented Apr 11, 2023

cmsbuild commented Apr 11, 2023

francescobrivio commented Apr 11, 2023

sunilUIET commented Apr 11, 2023

sunilUIET commented Apr 11, 2023

sunilUIET commented Apr 11, 2023

cmsbuild commented Apr 11, 2023

RelVals

RelVals-INPUT

sunilUIET commented Apr 13, 2023

cmsbuild commented Apr 13, 2023

cmsbuild commented Apr 13, 2023

cmsbuild commented Apr 13, 2023

Comparison Summary

sunilUIET commented Apr 13, 2023

srimanob commented Apr 17, 2023

cmsbuild commented Apr 17, 2023

perrotta Apr 17, 2023

Choose a reason for hiding this comment

srimanob Apr 18, 2023

Choose a reason for hiding this comment

perrotta commented Apr 18, 2023

swagata87 commented Apr 19, 2023

sunilUIET commented Apr 11, 2023 •

edited

Loading