Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OMS url link for BeamSpot DQM clients #41298

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

francescobrivio
Copy link
Contributor

PR description:

Fix OMS url for the BeamSpot DQM clients which was changed over the winter from:
http://cmsoms-services.cms:9949/urn:xdaq-application:lid=100/getRunAndLumiSection
to
http://cmsoms-eventing.cms:9949/urn:xdaq-application:lid=100/getRunAndLumiSection

PR validation:

None - to be tested online

Backport:

Backported in #41297

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41298/35092

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2023

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Apr 6, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f2184e/31871/summary.html
COMMIT: 81cf2ad
CMSSW: CMSSW_13_1_X_2023-04-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41298/31871/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 11 lines to the logs
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3459609
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3459584
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor Author

Just FYI the 13_0_X backport of this PR was deployed by @micsucmed and @syuvivida in online DQM this afternoon with Stable Beams and the issue observed in the morning was solved (upload of the BeamSpot payloads to the DB).

@perrotta
Copy link
Contributor

perrotta commented Apr 7, 2023

urgent
(because the 13_0_X backport was already tagges as "urgent": @cms-sw/dqm-l2 please review)

@cmsbuild cmsbuild added the urgent label Apr 7, 2023
@syuvivida
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Apr 7, 2023

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants