Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] Fix OMS url link for BeamSpot DQM clients #41297

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

francescobrivio
Copy link
Contributor

@francescobrivio francescobrivio commented Apr 6, 2023

PR description:

Fix OMS url for the BeamSpot DQM clients which was changed over the winter from:
http://cmsoms-services.cms:9949/urn:xdaq-application:lid=100/getRunAndLumiSection
to
http://cmsoms-eventing.cms:9949/urn:xdaq-application:lid=100/getRunAndLumiSection

PR validation:

None - to be tested online

Backport:

Backport of #41298

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2023

A new Pull Request was created by @francescobrivio for CMSSW_13_0_X.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

urgent

@cmsbuild cmsbuild added the urgent label Apr 6, 2023
@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@francescobrivio
Copy link
Contributor Author

backport of #41298

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2023

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-51a94e/31870/summary.html
COMMIT: 169394d
CMSSW: CMSSW_13_0_X_2023-04-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41297/31870/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3553952
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3553923
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

  • just relval input errors

@francescobrivio
Copy link
Contributor Author

Just FYI the this PR was deployed by @micsucmed and @syuvivida in online DQM this afternoon with Stable Beams and the issue observed in the morning was solved (upload of the BeamSpot payloads to the DB).

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-51a94e/31877/summary.html
COMMIT: 169394d
CMSSW: CMSSW_13_0_X_2023-04-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41297/31877/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 12 lines from the logs
  • Reco comparison results: 18 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3553952
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3553917
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@syuvivida
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 751ec4e into cms-sw:CMSSW_13_0_X Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants