Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for module veto and afterglow correction parameters [CMSSW_13_0_X] #41256

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

radla118
Copy link
Contributor

@radla118 radla118 commented Apr 3, 2023

PR description:

Backport of the PR #41242

PR validation:

Validated by running runTheMatrix.py -l 1020.0 configuration.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

The modified parameters are intended to be used for the 2023 data-taking period (CMSSW_13_0_X).

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2023

A new Pull Request was created by @radla118 for CMSSW_13_0_X.

It involves the following packages:

  • Calibration/LumiAlCaRecoProducers (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor

backport of #41242

@francescobrivio
Copy link
Contributor

test parameters:

  • workflow = 1020.0

@francescobrivio
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2023

-1

Failed Tests: AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-90dfd3/31758/summary.html
COMMIT: 9c8b04b
CMSSW: CMSSW_13_0_X_2023-04-03-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41256/31758/install.sh to create a dev area with all the needed externals and cmssw changes.

AddOn Tests

[fastsim1:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - elapsed time: 280 sec (ended on Mon Apr  3 14:45:10 2023) - exit: 35584

Comparison Summary

Summary:

  • You potentially removed 13 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3553952
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3553927
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 166 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Apr 3, 2023

@cms-sw/orp-l2 is this a known issue?

@tvami
Copy link
Contributor

tvami commented Apr 3, 2023

also tagging @cms-sw/fastsim-l2

@tvami
Copy link
Contributor

tvami commented Apr 3, 2023

@tvami
Copy link
Contributor

tvami commented Apr 3, 2023

urgent

  • we should include this in 13_0_3

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Apr 4, 2023

+1

  • The fastsim error does not look related to this PR: since it is said to be urgent, let have it merged for the next IB, and the following build of the 13_0_3 release

@perrotta
Copy link
Contributor

perrotta commented Apr 4, 2023

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants