Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Adding 2Loose HMT showers in the GT emulator #41249

Merged

Conversation

elfontan
Copy link
Contributor

PR description:

Update of the Global Trigger emulator for 2Loose HMT seeds (targeting the 2023 L1 menu).
It relies on the new utm library v0.11.2 recently integrated: cms-sw/cmsdist#8386.

This PR includes also an update of the GlobalBoard code to check the HMT condition for all BXs (see the discussion in cms-l1t-offline#1071). It should complete the fix of DQM issues at uGT with HMT observed during 2022. Backport to CMSSW_13_0_X in preparation.

Backport of #41211.

[cc: @dinyar @eyigitba @fmanteca]

PR validation:

Basic tests performed successfully starting from CMSSW_13_0_X_2023-03-31-1100

cmsrel CMSSW_13_0_X_2023-03-31-1100
cd CMSSW_13_0_X_2023-03-31-1100/src
cmsenv
scram b distclean
git cms-checkdeps -a -A
scram b -j 8
scram b runtests
scram build code-checks
scram build code-format

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 31, 2023

A new Pull Request was created by @elfontan (Elisa Fontanesi) for CMSSW_13_0_X.

It involves the following packages:

  • L1Trigger/L1TGlobal (l1)

@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@aloeliger
Copy link
Contributor

Backport of #41211

@aloeliger
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a34f07/31724/summary.html
COMMIT: 5d57693
CMSSW: CMSSW_13_0_X_2023-03-31-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41249/31724/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554479
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3554444
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Apr 2, 2023

+1

@cmsbuild cmsbuild merged commit 8dd4d24 into cms-sw:CMSSW_13_0_X Apr 2, 2023
@elfontan elfontan deleted the EF_uGT_2LooseHMT_backport130X branch April 3, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants