Adding 2Loose HMT showers in the GT emulator

[elfontan]

PR description:

Update of the Global Trigger emulator for 2Loose HMT seeds (targeting the 2023 L1 menu).
It relies on the new utm library v0.11.2 recently integrated: cms-sw/cmsdist#8386.

This PR includes also an update of the GlobalBoard code to check the HMT condition for all BXs (see the discussion in cms-l1t-offline#1071). It should complete the fix of DQM issues at uGT with HMT observed during 2022.

Backport to CMSSW_13_0_X: #41249.

[cc: @dinyar @eyigitba @fmanteca]

PR validation:

Basic tests performed successfully starting from CMSSW_13_1_X_2023-03-28-1100

cmsrel CMSSW_13_1_X_2023-03-28-1100
cd CMSSW_13_1_X_2023-03-28-1100/src
cmsenv
git cms-addpkg L1Trigger/L1TGlobal
git cms-addpkg L1Trigger/Configuration
scram b distclean
git cms-checkdeps -a -A
scram b -j 8
scram b runtests
scram build code-checks
scram build code-format

Changes for the L1Ntuples have been included as well: #41233.
A L1Ntuple [1] has been produced emulating a new menu [2] including the 2LooseHMT seed with the following recipe:

cmsDriver.py l1Ntuple -s RAW2DIGI --python_filename=data_def.py -n 10000 --no_output --era=Run3 --data --conditions=124X_dataRun3_Prompt_v4 --customise=L1Trigger/Configuration/customiseReEmul.L1TReEmulFromRAW --customise=L1Trigger/L1TNtuples/customiseL1Ntuple.L1NtupleRAWEMU --filein=/store/data/Commissioning2023/Cosmics/RAW/v2/000/365/300/00000/0bee10f0-6e0c-4efd-9ab5-c58993f0b709.root --customise=L1Trigger/Configuration/customiseUtils.L1TGlobalMenuXML --fileout=HMT_test_L1Ntuple.root
Note that the file L1Trigger/Configuration/python/customiseUtils.py has to be modify to use the new menu.

The output of the uGTEmuTree has been checked and includes countings for all the three HMT seeds:

L1_TwoMuShower_Loose (Bit 69): 98
L1_SingleMuShower_Nominal (Bit 101): 153
L1_SingleMuShower_Tight (Bit 102): 89

As discussed in HMT, at the moment all HMT rates are high and the reason is under investigation. Anyway, the uGT updates can be considered validated.

[1] /afs/cern.ch/work/e/elfontan/public/L1MenuTeamWork/HMT_test_L1Ntuple.root
[2] /afs/cern.ch/work/e/elfontan/public/L1MenuTeamWork/L1TMenu_test_HMT.xml (Bit 69)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41211/34917

• This PR adds an extra 40KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/L1TGlobal/plugins/TriggerMenuParser.cc modified in PR(s): Add HCAL LLP Jet Skim config #41111

[cmsbuild]

A new Pull Request was created by @elfontan (Elisa Fontanesi) for master.

It involves the following packages:

• L1Trigger/L1TGlobal (l1)

@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[aloeliger]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0ff451/31659/summary.html
COMMIT: e4ec80a
CMSSW: CMSSW_13_1_X_2023-03-28-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41211/31659/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
24234.61 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3554236
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3554205
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[aloeliger]

@elfontan This seems to pass most basic tests. Is there some other testing that is needed from your side on this PR?

[elfontan]

Hi @aloeliger,
yes, I still did not manage to run a complete test with a new xml menu calling this condition (most likely due to an unrelated problem, related to the current new menu instead). I would like to run a test and obtain some countings from the new condition before moving the PR to ready for review and prepare the backport to CMSSW_13_0_X.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41211/34978

• This PR adds an extra 60KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41211/34978/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41211/34978/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41211/34979

• This PR adds an extra 60KB to repository

[cmsbuild]

Pull request #41211 was updated. @epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41211/34985

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #41211 was updated. @epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please check and sign again.

[aloeliger]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0ff451/31721/summary.html
COMMIT: 9158f96
CMSSW: CMSSW_13_1_X_2023-03-31-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41211/31721/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 14 lines to the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3553709
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3553683
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

This fix closes cms-l1t-offline#1071

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1