Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HCAL LLP Jet Skim config #41226

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

kennedykiley
Copy link

PR description:

This PR adds the config for a RAW-AOD skim for HCAL-based LLP candidate events, based on new LLP trigger paths.
The HCAL RecHit skim saves the following collections in addition to standard RAW-AOD output:

HBHERecHit (via 'keep *_hbhereco__*')

The HCAL RecHit skim selects events passing the following HLT paths, which are included in the prompt HLT menu:

HLT*_L1SingleLLPJet_*

2022 LLP HLT Jira Ticket, 2023 Updated HCAL LLP HLT Jira Ticket

PR validation:

Tested with 1000 events from the following 2022 data sample in CMSSW_13_1_0_pre2:

/DisplacedJet/CMSSW_12_4_11-124X_dataRun3_Prompt_v4_gtval_RelVal_2022D-v1/RECO

Of the 1000 events tested, 87 passed the skim, with an average event size of about 0.7 MB. Note that the average event size of events in the unskimmed file is 3.2 MB.

The test script, generated with cmsDriver, is committed to this branch here: Configuration/Skimming/test/test_EXOLLPJetHCAL_SKIM.py

Backport:

Backport to CMSSW_13_0_X here: #41167

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41226/34943

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kennedykiley (Kiley Kennedy) for master.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@cmsbuild, @bbilin, @sunilUIET, @kskovpen can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos, @youyingli this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@youyingli
Copy link
Contributor

@perrotta I didn't see any conflict in this new PR replacing #41111. Could you please test it and its backport?

@youyingli
Copy link
Contributor

@perrotta , @kskovpen , if there is no concerning, could you please test it and its backport #41167 ?

@kskovpen
Copy link
Contributor

kskovpen commented Apr 4, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2023

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6e45e/31803/summary.html
COMMIT: a92dd30
CMSSW: CMSSW_13_1_X_2023-04-04-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41226/31803/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3365163
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3365141
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 202 log files, 155 edm output root files, 47 DQM output files
  • TriggerResults: no differences found

@youyingli
Copy link
Contributor

@kskovpen , the error should be a temporary incident ( link ). Could you please test again?

@kskovpen
Copy link
Contributor

kskovpen commented Apr 5, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6e45e/31829/summary.html
COMMIT: a92dd30
CMSSW: CMSSW_13_1_X_2023-04-04-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41226/31829/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 13 lines from the logs
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3365163
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3365132
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 202 log files, 155 edm output root files, 47 DQM output files
  • TriggerResults: no differences found

@youyingli
Copy link
Contributor

@kskovpen , could you just sign it and its backport as they are successfully tested if no concerning?

@kskovpen
Copy link
Contributor

kskovpen commented Apr 5, 2023

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants