Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HCAL LLP Jet Skim config (13_0_X) #41167

Merged

Conversation

kennedykiley
Copy link

@kennedykiley kennedykiley commented Mar 23, 2023

PR description:

This PR adds the config for a RAW-AOD skim for HCAL-based LLP candidate events, based on new LLP trigger paths.
The HCAL RecHit skim saves the following collections in addition to standard RAW-AOD output:

HBHERecHit (via 'keep *_hbhereco__*')

The HCAL RecHit skim selects events passing the following HLT paths, which are included in the prompt HLT menu:

HLT*_L1SingleLLPJet_*

2022 LLP HLT Jira Ticket, 2023 Updated HCAL LLP HLT Jira Ticket

PR validation:

Tested with the following 2022 data samples in CMSSW_13_0_0:

/DisplacedJet/CMSSW_12_4_11-124X_dataRun3_Prompt_v4_gtval_RelVal_2022D-v1/RECO

The skimmed file event size was 0.71 MB (87 total events) and the unskimmed file was 3.1 GB (1000 total events).

The test script, generated with cmsDriver, is committed to this branch here: Configuration/Skimming/test/test_EXOLLPJetHCAL_SKIM.py

Backport

Original PR: #41226

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 23, 2023

A new Pull Request was created by @kennedykiley (Kiley Kennedy) for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@cmsbuild, @bbilin, @sunilUIET, @kskovpen can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos, @youyingli this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

backport of #41111

@youyingli
Copy link
Contributor

@kennedykiley please update the PR description for backport. @perrotta now this PR is the backport of #41226 .

@kskovpen
Copy link
Contributor

kskovpen commented Apr 4, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-03dd5f/31804/summary.html
COMMIT: cb11610
CMSSW: CMSSW_13_0_X_2023-04-03-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41167/31804/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 9 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3553952
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3553930
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@kskovpen
Copy link
Contributor

kskovpen commented Apr 5, 2023

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Apr 6, 2023

backport of #41226

@perrotta
Copy link
Contributor

perrotta commented Apr 6, 2023

+1

@cmsbuild cmsbuild merged commit 8856c42 into cms-sw:CMSSW_13_0_X Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants