Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] Add L1 Stage2 Digis to Cosmics AOD event content #41150

Conversation

eyigitba
Copy link
Contributor

PR description:

As discussed in PPDC meeting we want to have L1 objects in Cosmics AOD event content. This PR adds required L1 stage2 digis to cosmics AOD event content.

This will make L1 displaced muon performance studies much easier to perform with cosmics data.

PR validation:

Validated by running reconstruction on cosmics RAW data from 2022 using:

cmsDriver.py reco -s RAW2DIGI,RECO --data --scenario cosmics --eventcontent AOD --filein /store/data/Run2022G/Cosmics/RAW/v1/000/362/363/00000/887de473-401c-4b6d-a9bb-66a32e35f446.root --fileout testAOD.root --conditions 124X_dataRun3_Prompt_v4 -n 1000 --era=Run3

I verified that the required digis now exist in the event content after the changes

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is the backport of #41149

@eyigitba eyigitba changed the title Adding L1 Stage2 Digis to Cosmics AOD event content [13_0_X] Add L1 Stage2 Digis to Cosmics AOD event content Mar 23, 2023
@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone Mar 23, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 23, 2023

A new Pull Request was created by @eyigitba for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/EventContent (operations)
  • L1Trigger/Configuration (l1)

@perrotta, @rappoccio, @epalencia, @cecilecaillol, @cmsbuild, @aloeliger, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@aloeliger
Copy link
Contributor

backport of #41149

@aloeliger
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-86e0cb/31547/summary.html
COMMIT: cbc0ed2
CMSSW: CMSSW_13_0_X_2023-03-22-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41150/31547/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3552993
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3552967
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@eyigitba
Copy link
Contributor Author

can this be merged as well since #41149 got merged?

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants