Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TnP code for GEM muon efficiency measurement for backport #41097

Merged
merged 2 commits into from
Mar 24, 2023

Conversation

qyguo
Copy link
Contributor

@qyguo qyguo commented Mar 19, 2023

It is a backport and links to the PR 41057
#41057

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 19, 2023

A new Pull Request was created by @qyguo for CMSSW_13_0_X.

It involves the following packages:

  • DQM/GEM (dqm)
  • DQMOffline/MuonDPG (dqm)

@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@barvic, @bellan, @abbiendi, @JanFSchulte, @jhgoh, @calderona, @HuguesBrun, @Fedespring, @watson-ij, @ptcox, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@watson-ij
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-716946/31421/summary.html
COMMIT: 28cd912
CMSSW: CMSSW_13_0_X_2023-03-19-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41097/31421/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3551048
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3551023
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 761.0560000000003 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 47.566 KiB GEM/Segment_TnP
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

type gem

@emanueleusai
Copy link
Member

backport of #41057

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Pull request #41097 was updated. @emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please check and sign again.

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-716946/31463/summary.html
COMMIT: fd208ce
CMSSW: CMSSW_13_0_X_2023-03-20-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41097/31463/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 4.674.67_ZElSkim2012C/step2_ZElSkim2012C.log
  • 1002.41002.4_RunDoubleMuon2022B/step2_RunDoubleMuon2022B.log
  • 11024.011024.0_TTbar_13+2018PU/step2_TTbar_13+2018PU.log
Expand to see more relval errors ...

Comparison Summary

Summary:

  • You potentially added 7 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3551048
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3551017
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 761.0560000000003 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 47.566 KiB GEM/Segment_TnP
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 0414fe0 into cms-sw:CMSSW_13_0_X Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants