Muon efficiency measurement for GEM

[qyguo]

Hi all experts, it is the code for Muon efficiency measurement for GEM detector. It is inherited from TnP framework of L. Lunerti (INFN Bologna) following the other sub-detector.
I did the test based on the CMSSW_13_1_0_pre1 framework.

We would like to add this in the next release for P5 and may I ask whether we need to make a backport for this?

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41057/34639

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41057/34639/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41057/34639/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41057/34671

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @qyguo for master.

It involves the following packages:

• DQM/GEM (dqm)
• DQMOffline/MuonDPG (dqm)

@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@barvic, @bellan, @abbiendi, @JanFSchulte, @jhgoh, @calderona, @HuguesBrun, @Fedespring, @watson-ij, @ptcox, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[watson-ij]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-651791/31318/summary.html
COMMIT: 2a0d4b1
CMSSW: CMSSW_13_1_X_2023-03-16-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41057/31318/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 34 lines to the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3550819
• DQMHistoTests: Total failures: 10
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3550787
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 761.0560000000003 KiB( 48 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): 47.566 KiB GEM/Segment_TnP
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

type gem

[emanueleusai]

@qyguo to deploy at p5 we need a backport to the 13_0 branch. Once you open the backport we will test it in our machines

[emanueleusai]

hold

• waiting for 13_0 backport and P5 tests

[cmsbuild]

Pull request #41057 was updated. @emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please check and sign again.

[perrotta]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-651791/31440/summary.html
COMMIT: 4c8c60a
CMSSW: CMSSW_13_1_X_2023-03-19-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41057/31440/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• You potentially removed 25 lines from the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3550882
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3550857
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 761.0560000000003 KiB( 48 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): 47.566 KiB GEM/Segment_TnP
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[watson-ij]

I'm not sure if this PR could cause the RelVal-INPUT to timeout?

[emanueleusai]

please test

[perrotta]

I'm not sure if this PR could cause the RelVal-INPUT to timeout?

No it doesn't: those timeouts are unfortunately appearing rather frequently in tests, and unless the PR touches exactly those workflows there is normally no need to waste resources and run the tests once again

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-651791/31462/summary.html
COMMIT: 4c8c60a
CMSSW: CMSSW_13_1_X_2023-03-20-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41057/31462/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 4.674.67_ZElSkim2012C/step2_ZElSkim2012C.log

Comparison Summary

Summary:

• You potentially added 27 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3550931
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3550906
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 761.0560000000003 KiB( 48 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): 47.566 KiB GEM/Segment_TnP
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[perrotta]

merge