extended existing HLT tau-jet correlation module #40993

brallmond · 2023-03-08T12:17:28Z

PR description:

To support a future VBF Single Tau HLT in the scenario that VBF Parking is accepted (see JIRA https://its.cern.ch/jira/browse/CMSLITDPG-1099 and https://its.cern.ch/jira/browse/CMSHLT-2702), a small change to an existing HLT module is necessary. The change extends the module's usage from only handling 2 Jet + 2 Tau events to also handling 2 Jet + 1 Tau events. This change depends on no other PRs and affects code used by one existing HLT path, and would allow the implementation of a future HLT path.

PR validation:

In the course of estimating rate and gain for the proposed VBF Single Tau path, the same metrics were also computed for the VBF DiTau path with the module extension in place and no differences were found in past and current behavior of the path.

cmsbuild · 2023-03-08T12:25:33Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40993/34502

This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40993/34502/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40993/34502/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40993/34502/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40993/34502/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2023-03-08T12:43:00Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40993/34504

This PR adds an extra 12KB to repository

cmsbuild · 2023-03-08T12:43:28Z

A new Pull Request was created by @brallmond (Braden Allmond) for master.

It involves the following packages:

RecoTauTag/HLTProducers (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@silviodonato, @missirol, @azotz, @mbluj this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

missirol

This update of the filter doesn't fit very well with the name of the plugin ("*WithDiTau"). One option is to add a copy of this plugin with a more suitable name (and we keep the current one in 13_1_X and 13_0_X for backward compatibility). This could be done by just doing

DEFINE_FWK_MODULE(HLTPFDiJetCorrCheckerWithDiTau);
using HLTDiPFJetPlusTauFilter = HLTPFDiJetCorrCheckerWithTaus;
DEFINE_FWK_MODULE(HLTDiPFJetPlusTausFilter);

Eventually (e.g. 13_2_X), the old plugin would be removed (and replaced at HLT by the new one). Thoughts?

the same metrics were also computed for the VBF DiTau path with the module extension in place and no differences were found in past and current behavior of the path.

As far as I understand, this is because that single use case in the current HLT is preceded by a filter requiring the input taus are at least 2. In general, this update changes the behaviour of the filter. Is that correct?

RecoTauTag/HLTProducers/src/HLTPFDiJetCorrCheckerWithDiTau.cc

brallmond · 2023-03-08T14:35:29Z

This update of the filter doesn't fit very well with the name of the plugin ("*WithDiTau"). One option is to add a copy of this plugin with a more suitable name (and we keep the current one in 13_1_X and 13_0_X for backward compatibility). This could be done by just doing
DEFINE_FWK_MODULE(HLTPFDiJetCorrCheckerWithDiTau);
using HLTDiPFJetPlusTauFilter = HLTPFDiJetCorrCheckerWithTaus;
DEFINE_FWK_MODULE(HLTDiPFJetPlusTausFilter);
Eventually (e.g. 13_2_X), the old plugin would be removed (and replaced at HLT by the new one). Thoughts?

Yes, I agree that's a good way to change the filter name in the future and proceed with the change. The code has been added. I think "HLTPFDiJetCorrCheckerWithTaus" above should have been "HLTPFDiJetCorrCheckerWithDiTau" so I changed it in the new commit

cmsbuild · 2023-03-08T14:37:18Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40993/34507

This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40993/34507/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40993/34507/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

RecoTauTag/HLTProducers/src/HLTPFDiJetCorrCheckerWithDiTau.cc

missirol · 2023-03-08T14:41:51Z

I think "HLTPFDiJetCorrCheckerWithTaus" above should have been "HLTPFDiJetCorrCheckerWithDiTau" so I changed it in the new commit

Right, sorry for the confusion.

cmsbuild · 2023-03-08T14:50:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40993/34508

This PR adds an extra 16KB to repository

cmsbuild · 2023-03-08T20:20:37Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6880f2/31147/summary.html
COMMIT: 66f9c28
CMSSW: CMSSW_13_1_X_2023-03-08-1300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40993/31147/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 13 lines to the logs
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3530381
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3530350
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

RecoTauTag/HLTProducers/src/HLTPFDiJetCorrCheckerWithDiTau.cc

cmsbuild · 2023-03-09T11:46:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40993/34528

This PR adds an extra 12KB to repository

cmsbuild · 2023-03-09T11:46:46Z

Pull request #40993 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

missirol · 2023-03-09T12:35:04Z

please test

(Didn't squash in 1 commit, but having 3 commits is not a problem, imho.)

cmsbuild · 2023-03-09T15:54:44Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6880f2/31161/summary.html
COMMIT: 5335974
CMSSW: CMSSW_13_1_X_2023-03-08-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40993/31161/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 4 lines to the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3530381
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3530358
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

missirol · 2023-03-09T19:32:04Z

+hlt

extends the logic of an existing HLT filter
does not change the results of the current HLT menu
adds a copy of the plugin with a clearer name, to be adopted in future HLT menus (to be done in CMSHLT-2700)

cmsbuild · 2023-03-09T19:32:26Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2023-03-09T21:07:39Z

+1

cmsbuild added this to the CMSSW_13_1_X milestone Mar 8, 2023

cmsbuild added hlt-pending pending-signatures tests-pending orp-pending code-checks-pending labels Mar 8, 2023

brallmond mentioned this pull request Mar 8, 2023

extended existing HLT tau-jet correlation module [13_0_X] #40990

Merged

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Mar 8, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 8, 2023

missirol reviewed Mar 8, 2023

View reviewed changes

RecoTauTag/HLTProducers/src/HLTPFDiJetCorrCheckerWithDiTau.cc Outdated Show resolved Hide resolved

RecoTauTag/HLTProducers/src/HLTPFDiJetCorrCheckerWithDiTau.cc Outdated Show resolved Hide resolved

cmsbuild added code-checks-pending and removed code-checks-approved labels Mar 8, 2023

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 8, 2023

missirol reviewed Mar 8, 2023

View reviewed changes

RecoTauTag/HLTProducers/src/HLTPFDiJetCorrCheckerWithDiTau.cc Outdated Show resolved Hide resolved

RecoTauTag/HLTProducers/src/HLTPFDiJetCorrCheckerWithDiTau.cc Outdated Show resolved Hide resolved

cmsbuild added code-checks-pending and removed code-checks-rejected labels Mar 8, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 8, 2023

cmsbuild added tests-approved and removed tests-started labels Mar 8, 2023

missirol reviewed Mar 8, 2023

View reviewed changes

RecoTauTag/HLTProducers/src/HLTPFDiJetCorrCheckerWithDiTau.cc Outdated Show resolved Hide resolved

RecoTauTag/HLTProducers/src/HLTPFDiJetCorrCheckerWithDiTau.cc Outdated Show resolved Hide resolved

extended existing HLT tau-jet correlation module

5335974

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Mar 9, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 9, 2023

cmsbuild added tests-started and removed tests-pending labels Mar 9, 2023

cmsbuild added tests-approved and removed tests-started labels Mar 9, 2023

cmsbuild added hlt-approved fully-signed and removed hlt-pending pending-signatures labels Mar 9, 2023

cmsbuild added orp-approved and removed orp-pending labels Mar 9, 2023

cmsbuild merged commit c07d8e8 into cms-sw:master Mar 9, 2023

missirol mentioned this pull request Apr 2, 2023

remove duplicate plugin HLTPFDiJetCorrCheckerWithDiTau #41254

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

extended existing HLT tau-jet correlation module #40993

extended existing HLT tau-jet correlation module #40993

brallmond commented Mar 8, 2023 •

edited

Loading

cmsbuild commented Mar 8, 2023

cmsbuild commented Mar 8, 2023

cmsbuild commented Mar 8, 2023

missirol left a comment

brallmond commented Mar 8, 2023

cmsbuild commented Mar 8, 2023

missirol commented Mar 8, 2023

cmsbuild commented Mar 8, 2023

cmsbuild commented Mar 8, 2023

cmsbuild commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

missirol commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

missirol commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

rappoccio commented Mar 9, 2023

extended existing HLT tau-jet correlation module #40993

extended existing HLT tau-jet correlation module #40993

Conversation

brallmond commented Mar 8, 2023 • edited Loading

cmsbuild commented Mar 8, 2023

cmsbuild commented Mar 8, 2023

cmsbuild commented Mar 8, 2023

missirol left a comment

Choose a reason for hiding this comment

brallmond commented Mar 8, 2023

cmsbuild commented Mar 8, 2023

missirol commented Mar 8, 2023

cmsbuild commented Mar 8, 2023

cmsbuild commented Mar 8, 2023

Comparison Summary

cmsbuild commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

missirol commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

Comparison Summary

missirol commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

rappoccio commented Mar 9, 2023

brallmond commented Mar 8, 2023 •

edited

Loading