Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extended existing HLT tau-jet correlation module [13_0_X] #40990

Merged
merged 2 commits into from
Mar 10, 2023
Merged

extended existing HLT tau-jet correlation module [13_0_X] #40990

merged 2 commits into from
Mar 10, 2023

Conversation

brallmond
Copy link
Contributor

@brallmond brallmond commented Mar 8, 2023 •
edited
Loading

PR description:

To support a future VBF Single Tau HLT in the scenario that VBF Parking is accepted (see JIRA https://its.cern.ch/jira/browse/CMSLITDPG-1099 and https://its.cern.ch/jira/browse/CMSHLT-2702), a small change to an existing HLT module is necessary. The change extends the module's usage from only handling 2 Jet + 2 Tau events to also handling 2 Jet + 1 Tau events. This change depends on no other PRs and affects code used by one existing HLT path, and would allow the implementation of a future HLT path.

PR validation:

In the course of estimating rate and gain for the proposed VBF Single Tau path, the same metrics were also computed for the VBF DiTau path with the module extension in place and no differences were found in past and current behavior of the path.

Backport

master PR is #40993
It's necessary to Backport this change as current testing and HLT development is taking place in CMSSW_13_0_0

@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone Mar 8, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2023 •
edited
Loading

A new Pull Request was created by @brallmond (Braden Allmond) for CMSSW_13_0_X.

It involves the following packages:

  • RecoTauTag/HLTProducers (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@silviodonato, @missirol, @azotz, @mbluj this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor

Please make a PR to the master CMSSW branch as well so that this backport can be integrated with the master being up to date as well.

Martin-Grunewald
Martin-Grunewald reviewed Mar 8, 2023
View reviewed changes
RecoTauTag/HLTProducers/src/HLTPFDiJetCorrCheckerWithDiTau.cc Outdated
break;
if (taus.size() == 1) { correctComb = true; }

if (taus.size() > 1) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just use else since you checked size()>0 already above....

@brallmond
Copy link
Contributor Author

Please make a PR to the master CMSSW branch as well so that this backport can be integrated with the master being up to date as well.

Okay, when I tried to integrate with master originally, there were 78+ commits included from other PRs. Is this intended?

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2023

Pull request #40990 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor

You'd need to rebase to 13_1_X or start from a recent 13_1_X developer area to make the PR.

@brallmond
Copy link
Contributor Author

You'd need to rebase to 13_1_X or start from a recent 13_1_X developer area to make the PR.

Okay, I've made a new PR (#40993) to 13_1_X with the same change, and edited the description of the PR in this thread to show it is a backport to 13_0_0. Please let me know if this is acceptable

@Martin-Grunewald
Copy link
Contributor

Martin-Grunewald commented Mar 8, 2023 •
edited
Loading

OK, looks good - but please apply the 131x code format patches there and also here.

@perrotta
Copy link
Contributor

perrotta commented Mar 8, 2023

backport of #40993

@brallmond brallmond changed the title extended existing HLT module to handle 2Jet + 1Tau events in addition… extended existing HLT tau-jet correlation module [13_0_X] Mar 8, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2023

Pull request #40990 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@missirol
Copy link
Contributor

missirol commented Mar 8, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-66b06e/31148/summary.html
COMMIT: 0e463f6
CMSSW: CMSSW_13_0_X_2023-03-08-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40990/31148/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 16 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3557934
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3557906
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2023

Pull request #40990 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@missirol
Copy link
Contributor

missirol commented Mar 9, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-66b06e/31162/summary.html
COMMIT: 7274406
CMSSW: CMSSW_13_0_X_2023-03-09-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40990/31162/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 13 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3557934
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3557906
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

missirol commented Mar 9, 2023

+hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 300f9aa into cms-sw:CMSSW_13_0_X Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Martin-Grunewald Martin-Grunewald Martin-Grunewald left review comments

Assignees
No one assigned
Labels
backport-ok fully-signed hlt-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_13_0_X
Development

Successfully merging this pull request may close these issues.
5 participants
@brallmond @cmsbuild @Martin-Grunewald @perrotta @missirol