Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-alca238X Modify the output content for 2 isolated bunch AlCaReco modules of HCAL (backporting PR #40952 to CMSSW_13_0_X) #40955

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Mar 3, 2023

PR description:

Modify the output content for 2 isolated bunch AlCaReco modules of HCAL (back porting PR #40952 to CMSSW_13_0_X)

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of PR #40952

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2023

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_13_0_X.

It involves the following packages:

  • Calibration/HcalAlCaRecoProducers (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Mar 3, 2023

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd86b9/31049/summary.html
COMMIT: 39fee83
CMSSW: CMSSW_13_0_X_2023-03-03-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40955/31049/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 17 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3557934
  • DQMHistoTests: Total failures: 17
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3557895
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Mar 13, 2023

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mariadalfonso
Copy link
Contributor

mariadalfonso commented Mar 13, 2023

for the record: this is a fix will need for future 2023 Prompt-RECO/Tier0 (during real collision)
--> we will need to add in a future patch release
( HcalCalIsolatedBunchSelector is part of the ZeroBias0-ALCARECO https://github.com/dmwm/T0/blob/master/etc/ProdOfflineConfiguration.py#L1169 )

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4c47692 into cms-sw:CMSSW_13_0_X Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants