Run3-alca238 Modify the output content for 2 isolated bunch AlCaReco modules of HCAL

[bsunanda]

PR description:

Modify the output content for 2 isolated bunch AlCaReco modules of HCAL. The isolated bunch AlCaReco files are rather small (# of isolated bunch events is small as well). The change will affect less than 10% increase.

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Need to be back ported to 13_0_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40952/34435

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Calibration/HcalAlCaRecoProducers (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[tvami]

Hi @bsunanda what is the size increase by doing this?

[bsunanda]

This is a very small dataset (isolated bunch) and the expected change is ~10%

[bsunanda]

@cmsbuild Please test

[tvami]

Is the ALCARECO the HcalCalIsolatedBunchFilter ? I dont see that being part of the AlCaRECO matrix now
https://github.com/cms-sw/cmssw/blob/master/Configuration/AlCa/python/autoAlca.py

[tvami]

@cmsbuild Please test

is the ALCARECO run for the default tests?

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f97375/31048/summary.html
COMMIT: a7d685c
CMSSW: CMSSW_13_1_X_2023-03-03-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40952/31048/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 32 lines to the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3529699
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3529670
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

is the ALCARECO run for the default tests?

Seems not, @bsunanda please trigger tests that do create this ALCARECO, thanks

[bsunanda]

I do not think there is a AlCaReco test for isolated bunch

…

________________________________ From: Tamas Vami ***@***.***> Sent: 04 March 2023 20:31 To: cms-sw/cmssw ***@***.***> Cc: Sunanda Banerjee ***@***.***>; Mention ***@***.***> Subject: Re: [cms-sw/cmssw] Run3-alca238 Modify the output content for 2 isolated bunch AlCaReco modules of HCAL (PR #40952) is the ALCARECO run for the default tests? Seems not, @bsunanda<https://github.com/bsunanda> please trigger tests that do create this ALCARECO, thanks — Reply to this email directly, view it on GitHub<#40952 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOWCL7GA4TW3DKBMXM3W2NKLXANCNFSM6AAAAAAVOYEENA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[bsunanda]

@tvami Please approve this PR.

[tvami]

Is the ALCARECO the HcalCalIsolatedBunchFilter ? I dont see that being part of the AlCaRECO matrix now https://github.com/cms-sw/cmssw/blob/master/Configuration/AlCa/python/autoAlca.py

@bsunanda I didnt receive an answer to this ^

[bsunanda]

@tvami It should be. I shall make a PR to make it a part of autoAlca.py

[bsunanda]

@cmsbuild Please test with #40970

[bsunanda]

@tvami I am testing the 2 PR's together. Once the tests are done please approve the PR's. We need them in early 2023 runs in CMSSW_13_0_X

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f97375/31184/summary.html
COMMIT: a7d685c
CMSSW: CMSSW_13_1_X_2023-03-09-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40952/31184/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 5 lines from the logs
• Reco comparison results: 25 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3530381
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3530355
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.016 KiB( 48 files compared)
• DQMHistoSizes: changed ( 1000.0 ): 0.008 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 1000.0 ): 0.008 KiB MessageLogger/Warnings
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[bsunanda]

@tvami Please check the latest test results

[tvami]

You didnt test 1002.3 and 1002.4 as I've asked in the other PR. I'll do it now

[tvami]

test parameters:

• workflows = 1002.3,1002.4
• pull_request = Run3-alca240 Add one more isolated bunch AlCaReco to the AlCa matrix #40970

[tvami]

@cmsbuild , please test

[tvami]

Now we are testing the changes...

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f97375/31197/summary.html
COMMIT: a7d685c
CMSSW: CMSSW_13_1_X_2023-03-10-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40952/31197/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 43 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3647632
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 2
• DQMHistoTests: Total successes: 3647604
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.032 KiB( 50 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): 0.008 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 1000.0,... ): 0.008 KiB MessageLogger/Warnings
• Checked 220 log files, 166 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• now the HcalCalIsolatedBunchFilter is produced in the test

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1