Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] Allow access to const edm::{Event,EventSetup} from device::{Event,EventSetup} #40935

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Mar 2, 2023

PR description:

Backport of #40849. Original PR description

Giving access to edm::{Event,EventSetup} from device::{Event,EventSetup} allows interaction with helper code needing edm::{Event,EventSetup} from Alpaka EDModules.

PR validation:

None beyond #40849

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #40849 to support Alpaka development (and eventual deployment) in 13_0_X.

…ntSetup}

To be able to interact with helper code needing
edm::{Event,EventSetup} from Alpaka EDModules.
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2023

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_13_0_X.

It involves the following packages:

  • HeterogeneousCore/AlpakaCore (heterogeneous)
  • HeterogeneousCore/AlpakaTest (heterogeneous)

@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks.
@missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor

fwyzard commented Mar 2, 2023

backport #40849

@fwyzard
Copy link
Contributor

fwyzard commented Mar 2, 2023

please test

@fwyzard
Copy link
Contributor

fwyzard commented Mar 2, 2023

+heterogeneous

Exact same commit as the 13.1.x counterpart, #40849.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@fwyzard
Copy link
Contributor

fwyzard commented Mar 2, 2023

urgent

As mentioned at the ORP this week, I would like to have this in 13_0_0, if possible.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f58f16/31011/summary.html
COMMIT: abba246
CMSSW: CMSSW_13_0_X_2023-03-02-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40935/31011/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 26 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3557934
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3557906
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Mar 3, 2023

+1

@cmsbuild cmsbuild merged commit ec8b3d9 into cms-sw:CMSSW_13_0_X Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants