Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow access to const edm::{Event,EventSetup} from device::{Event,EventSetup} #40849

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Allow access to const edm::{Event,EventSetup} from device::{Event,EventSetup} #40849

merged 1 commit into from
Mar 2, 2023

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Feb 22, 2023 •
edited
Loading

PR description:

Giving access to edm::{Event,EventSetup} from device::{Event,EventSetup} allows interaction with helper code needing edm::{Event,EventSetup} from Alpaka EDModules.

Need came up in a work by @AdrianoDee

PR validation:

Code compiles

@cmsbuild cmsbuild added this to the CMSSW_13_1_X milestone Feb 22, 2023
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40849/34305

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

  • HeterogeneousCore/AlpakaCore (heterogeneous)

@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks.
@missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4eaaa6/30824/summary.html
COMMIT: c375791
CMSSW: CMSSW_13_1_X_2023-02-22-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40849/30824/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
11634.596 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 38 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3528709
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3528684
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@makortel makortel mentioned this pull request Feb 24, 2023
Closed
2 tasks
@perrotta
Copy link
Contributor

perrotta commented Mar 1, 2023 •
edited
Loading

@makortel @fwyzard this PR was among the ones that was supposed to enter pre1, but it seems stuck since one week already. Do you think you can reach any conclusion about it in the next 20' (oh yes; sorry for that), or should we move it to pre2 instead?

@fwyzard
Copy link
Contributor

fwyzard commented Mar 1, 2023

skip it :-)

@makortel
Allow access to const edm::{Event,EventSetup} from device::{Event,Eve…
abba246 
…ntSetup}

To be able to interact with helper code needing
edm::{Event,EventSetup} from Alpaka EDModules.
@makortel makortel force-pushed the alpakaDeviceEventExpose branch from c375791 to abba246 Compare March 2, 2023 16:46
@makortel
Copy link
Contributor Author

makortel commented Mar 2, 2023

Rebased on top of 5ebe8d8 (tip of #40725, and last commit of #40832 before a merge commit from 13_1_X), and moved to use the implicit conversion operator.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40849/34420

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2023

Pull request #40849 was updated. @cmsbuild, @makortel, @fwyzard can you please check and sign again.

@fwyzard
Copy link
Contributor

fwyzard commented Mar 2, 2023

please test

@fwyzard
Copy link
Contributor

fwyzard commented Mar 2, 2023

+heterogeneous

The changes to the code and tests look good.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@fwyzard
Copy link
Contributor

fwyzard commented Mar 2, 2023

urgent

To be backported to 13.0.x for CMSSW_13_0_0.

@cmsbuild cmsbuild added the urgent label Mar 2, 2023
@makortel makortel mentioned this pull request Mar 2, 2023
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4eaaa6/31009/summary.html
COMMIT: abba246
CMSSW: CMSSW_13_1_X_2023-03-02-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40849/31009/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 12 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3529699
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3529669
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Mar 2, 2023

+1

@cmsbuild cmsbuild merged commit bdc7d19 into cms-sw:master Mar 2, 2023
@makortel makortel deleted the alpakaDeviceEventExpose branch March 3, 2023 14:24
@makortel makortel mentioned this pull request Mar 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwyzard fwyzard fwyzard left review comments

Assignees
No one assigned
Labels
code-checks-approved fully-signed heterogeneous-approved orp-approved tests-approved urgent
Projects
None yet
Milestone
CMSSW_13_1_X
Development

Successfully merging this pull request may close these issues.
4 participants
@makortel @cmsbuild @perrotta @fwyzard