Fix Tracks related Pixel quantities at HLT DQM #40873

arossi83 · 2023-02-24T10:49:29Z

PR description:

Monitor of the tracks related Pixel quantities at HLT DQM never works and it was disabled at some point, with this PR we introduce the changes needed (tracks refitting) in order to be able to monitor Pixel Tracks quantities at HLT DQM.
In this PR we also update the collection to be used by the Standard DQM Pixel Residuals Monitor in order to use the refitted tracks.

PR validation:

runTheMatrix.sh -l 140.063
Manually run the Online HLT client at P5 with old stored DQM stream file

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport to 13_0_X will be needed since it's the release which will be used for 2023 datataking

arossi83 · 2023-02-24T10:49:59Z

@mmusich @cardinia @antoniovagnerini FYI

mmusich · 2023-02-24T10:52:49Z

resolves #30911

mmusich · 2023-02-24T10:53:07Z

resolves CMSTrackerDPG/Tasks#5

mmusich · 2023-02-24T10:54:47Z

test parameters:

workflow = 140.063

cmsbuild · 2023-02-24T10:58:11Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40873/34341

This PR adds an extra 24KB to repository

cmsbuild · 2023-02-24T10:58:30Z

A new Pull Request was created by @arossi83 (Alessandro Rossi) for master.

It involves the following packages:

DQM/Integration (dqm)
DQM/SiPixelPhase1Track (dqm)
DQMOffline/Trigger (dqm)

@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@fioriNTU, @arossi83, @trocino, @batinkov, @hdelanno, @battibass, @sroychow, @jhgoh, @missirol, @HuguesBrun, @Fedespring, @threus, @jandrea, @idebruyn, @mmusich, @rociovilar, @mtosi, @cericeci, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

mmusich · 2023-02-24T10:59:56Z

@cmsbuild, please test

mmusich · 2023-02-24T13:36:46Z

DQMOffline/Trigger/python/SiPixel_OfflineMonitoring_cff.py

-    #+ hltSiPixelPhase1TrackClustersAnalyzer
+    hltSiPixelClusterShapeCache
+    + hltSiPixelPhase1ClustersAnalyzer
+    + refittedForPixelDQM


shouldn't this be

Suggested change

+ refittedForPixelDQM

+ hltrefittedForPixelDQM

?

Yes, It should. Just push a commit to fix it.

Thanks, can you apply the rest of the suggestions at #40875 (comment) ? In that way we should be passing tests without need to change any input.

Done, sorry I overlooked the comments yesterday

cmsbuild · 2023-02-24T14:21:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40873/34342

This PR adds an extra 16KB to repository

cmsbuild · 2023-02-25T08:32:19Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40873/34355

This PR adds an extra 28KB to repository

cmsbuild · 2023-02-25T08:32:46Z

Pull request #40873 was updated. @micsucmed, @emanueleusai, @clacaputo, @cmsbuild, @syuvivida, @pmandrik, @mandrenguyen, @rvenditti can you please check and sign again.

mmusich · 2023-02-25T08:41:31Z

@cmsbuild, please test

cmsbuild · 2023-02-25T11:49:16Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-573eb9/30902/summary.html
COMMIT: 1560208
CMSSW: CMSSW_13_1_X_2023-02-24-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40873/30902/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 7 lines from the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3616346
DQMHistoTests: Total failures: 7003
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3609321
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 23549.645 KiB( 49 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 3364.235 KiB HLT/Pixel
Checked 217 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

emanueleusai · 2023-02-27T00:55:56Z

Hello let's see if we can track down all the changes in the DQM comparisons:

Stark increase DQMHistoSizes memory --> adding back tracks related Pixel quantities at HLT DQM plots OK
124 plots added in 7 workflows --> caused by addition of hltrefittedForPixelDQM module OK
you mention you are now using the refitted collection to monitor Standard DQM Pixel Residuals, so I see differences in Tracks/ResidualsExtra and beyond ResidualsExtra, in other Track/* folders in plots with name pattern residual* . Do you expect the differences in the residuals when using the refitted track collection?
I see differences in EgammaV/ConversionValidator/ConversionInfo https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_13_1_X_2023-02-24-2300+573eb9/55726/11634.7_TTbar_14TeV+2021_trackingMkFit/EgammaV_ConversionValidator_ConversionInfo.html but that is perhaps unrelated.

mmusich · 2023-02-27T04:38:01Z

Hi @emanueleusai,
since this PR packages together different updates, allow me to give some more information here:

Stark increase DQMHistoSizes memory --> adding back tracks related Pixel quantities at HLT DQM plots OK

This is needed to be able to monitor the performance of the pixel detector - as seen by the HLT - during 2024, as we we expect it to have to cope with unprecedentedly hard conditions from the machine (well beyond the specs of the readout chip at the peak luminosity during the luminosity leveling phase of the fill). This will help to track down possible sources of tracking inefficiency at the HLT.

Do you expect the differences in the residuals when using the refitted track collection?

Yes, this in fact corrects a "bug" in the offline pixel DQM. Since when the trajectory is a transient event product, in order to compute precise residuals a refit of the track is needed. If that is not provided the DQM module falls back to use the pre-computed track residuals, stored in the TrackExtra branch, at lower precision.
The aim here is to provide an "online" measurement more similar to the one performed "offline" by the tracker alignment group.

I see differences in EgammaV/ConversionValidator/ConversionInfo https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_13_1_X_2023-02-24-2300+573eb9/55726/11634.7_TTbar_14TeV+2021_trackingMkFit/EgammaV_ConversionValidator_ConversionInfo.html but that is perhaps unrelated.

This indeed looks unrelated, and instead potentially related to the known instability of wf 11634.7, as reported already in a separate issue: #39803

emanueleusai · 2023-02-27T04:40:48Z

Thank you very much for the detailed follow-up. Everything is understood and as expected from the code changes.

emanueleusai · 2023-02-27T04:40:54Z

+1

mandrenguyen · 2023-02-27T13:00:18Z

+1

cmsbuild · 2023-02-27T13:00:43Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta

Given the urgency of the backport, to be ready in time for 13_0_0, please apply this fix in a forthcoming PR while we are merging this one. Possibly now, so that it can be also merged in the backport

perrotta · 2023-02-27T13:20:46Z

DQMOffline/Trigger/python/SiPixel_OfflineMonitoring_cff.py


+hltSiPixelClusterShapeCache = siPixelClusterShapeCache.clone(src = 'hltSiPixelClusters')
+hltrefittedForPixelDQM = refittedForPixelDQM.clone(src ='hltMergedTracks',
+                                                   TTRHBuilder = cms.string('WithTrackAngle')) # no templates at HLT


Suggested change

TTRHBuilder = cms.string('WithTrackAngle')) # no templates at HLT

TTRHBuilder = 'WithTrackAngle') # no templates at HLT

to speed up things here's the fix in master: #40891.
Hopefully @arossi83 can do the same in #40875.

perrotta · 2023-02-27T13:39:24Z

+1

Alessandro Rossi added 2 commits February 22, 2023 16:50

Introduce track refitting in HLT DQM for Pixel Tracks quantities

2e513f9

Add Pixel Template to HLT Online client

f69a87a

cmsbuild added this to the CMSSW_13_1_X milestone Feb 24, 2023

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending code-checks-pending trk labels Feb 24, 2023

arossi83 mentioned this pull request Feb 24, 2023

Fix Tracks related Pixel quantities at HLT DQM (backport) #40875

Merged

mmusich mentioned this pull request Feb 24, 2023

Phase-1 Pixel DQM at HLT is missing most of the plots CMSTrackerDPG/Tasks#5

Open

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 24, 2023

cmsbuild added tests-started and removed tests-pending labels Feb 24, 2023

mmusich reviewed Feb 24, 2023

View reviewed changes

Fix a typo on SiPixel_OfflineMonitor sequence

6804460

cmsbuild added tests-pending code-checks-pending and removed tests-started code-checks-approved labels Feb 24, 2023

cmsbuild removed the code-checks-pending label Feb 24, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 25, 2023

cmsbuild added tests-started and removed tests-pending labels Feb 25, 2023

cmsbuild added tests-approved and removed tests-started labels Feb 25, 2023

cmsbuild added dqm-approved and removed dqm-pending labels Feb 27, 2023

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Feb 27, 2023

perrotta reviewed Feb 27, 2023

View reviewed changes

cmsbuild added orp-approved and removed orp-pending labels Feb 27, 2023

cmsbuild merged commit 386ca31 into cms-sw:master Feb 27, 2023

mmusich mentioned this pull request Feb 27, 2023

drop cms type specification in SiPixel_OfflineMonitoring_cff #40891

Merged

cmsbuild mentioned this pull request Feb 27, 2023

Update muon shower data formats for 2023 running #40890

Merged

missirol mentioned this pull request Mar 1, 2023

avoid duplicates in HLTPMMassFilter plugin #40918

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Tracks related Pixel quantities at HLT DQM #40873

Fix Tracks related Pixel quantities at HLT DQM #40873

arossi83 commented Feb 24, 2023 •

edited

Loading

arossi83 commented Feb 24, 2023

mmusich commented Feb 24, 2023

mmusich commented Feb 24, 2023

mmusich commented Feb 24, 2023

cmsbuild commented Feb 24, 2023

cmsbuild commented Feb 24, 2023

mmusich commented Feb 24, 2023

mmusich Feb 24, 2023

arossi83 Feb 24, 2023

mmusich Feb 24, 2023

arossi83 Feb 25, 2023

cmsbuild commented Feb 24, 2023

cmsbuild commented Feb 25, 2023

cmsbuild commented Feb 25, 2023

mmusich commented Feb 25, 2023

cmsbuild commented Feb 25, 2023

emanueleusai commented Feb 27, 2023

mmusich commented Feb 27, 2023 •

edited

Loading

emanueleusai commented Feb 27, 2023

emanueleusai commented Feb 27, 2023

mandrenguyen commented Feb 27, 2023

cmsbuild commented Feb 27, 2023

perrotta left a comment

perrotta Feb 27, 2023

mmusich Feb 27, 2023

perrotta commented Feb 27, 2023

	TTRHBuilder = cms.string('WithTrackAngle')) # no templates at HLT
	TTRHBuilder = 'WithTrackAngle') # no templates at HLT

Fix Tracks related Pixel quantities at HLT DQM #40873

Fix Tracks related Pixel quantities at HLT DQM #40873

Conversation

arossi83 commented Feb 24, 2023 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

arossi83 commented Feb 24, 2023

mmusich commented Feb 24, 2023

mmusich commented Feb 24, 2023

mmusich commented Feb 24, 2023

cmsbuild commented Feb 24, 2023

cmsbuild commented Feb 24, 2023

mmusich commented Feb 24, 2023

mmusich Feb 24, 2023

Choose a reason for hiding this comment

arossi83 Feb 24, 2023

Choose a reason for hiding this comment

mmusich Feb 24, 2023

Choose a reason for hiding this comment

arossi83 Feb 25, 2023

Choose a reason for hiding this comment

cmsbuild commented Feb 24, 2023

cmsbuild commented Feb 25, 2023

cmsbuild commented Feb 25, 2023

mmusich commented Feb 25, 2023

cmsbuild commented Feb 25, 2023

Comparison Summary

emanueleusai commented Feb 27, 2023

mmusich commented Feb 27, 2023 • edited Loading

emanueleusai commented Feb 27, 2023

emanueleusai commented Feb 27, 2023

mandrenguyen commented Feb 27, 2023

cmsbuild commented Feb 27, 2023

perrotta left a comment

Choose a reason for hiding this comment

perrotta Feb 27, 2023

Choose a reason for hiding this comment

mmusich Feb 27, 2023

Choose a reason for hiding this comment

perrotta commented Feb 27, 2023

arossi83 commented Feb 24, 2023 •

edited

Loading

mmusich commented Feb 27, 2023 •

edited

Loading