-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.6.X] Ensure that egamma picks up 2023 HB thresholds for 12_6_X MC production #40756
Merged
+20
−1
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
from Configuration.Eras.Era_Run2_2018_cff import Run2_2018 | ||
from Configuration.Eras.Modifier_run3_common_cff import run3_common | ||
from Configuration.Eras.Modifier_run3_GEM_cff import run3_GEM | ||
from Configuration.Eras.Modifier_run3_HB_cff import run3_HB | ||
from Configuration.Eras.Modifier_run3_HFSL_cff import run3_HFSL | ||
from Configuration.Eras.Modifier_run2_GEM_2017_cff import run2_GEM_2017 | ||
from Configuration.Eras.Modifier_stage2L1Trigger_2021_cff import stage2L1Trigger_2021 | ||
from Configuration.Eras.Modifier_ctpps_2018_cff import ctpps_2018 | ||
from Configuration.Eras.Modifier_ctpps_2022_cff import ctpps_2022 | ||
from Configuration.ProcessModifiers.dd4hep_cff import dd4hep | ||
from Configuration.Eras.Modifier_run3_egamma_cff import run3_egamma | ||
from Configuration.Eras.Modifier_run2_egamma_2018_cff import run2_egamma_2018 | ||
from Configuration.Eras.Modifier_run3_RPC_cff import run3_RPC | ||
from Configuration.Eras.Modifier_run3_egamma_2023_cff import run3_egamma_2023 | ||
|
||
Run3_2023 = cms.ModifierChain(Run2_2018.copyAndExclude([run2_GEM_2017, ctpps_2018, run2_egamma_2018]), | ||
run3_common, run3_egamma, run3_egamma_2023, run3_GEM, run3_HB, run3_HFSL, stage2L1Trigger_2021, ctpps_2022, dd4hep, run3_RPC) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
run3_egamma_2023 =cms.Modifier() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 8 additions & 1 deletion
9
RecoEgamma/EgammaIsolationAlgos/python/egammaHBHERecHitThreshold_cff.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,17 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
from RecoParticleFlow.PFClusterProducer.particleFlowRecHitHBHE_cfi import _thresholdsHBphase1, _thresholdsHEphase1 | ||
from RecoParticleFlow.PFClusterProducer.particleFlowRecHitHBHE_cfi import _thresholdsHBphase1, _thresholdsHEphase1, _thresholdsHBphase1_2023 | ||
|
||
egammaHBHERecHit = cms.PSet( | ||
hbheRecHits = cms.InputTag('hbhereco'), | ||
recHitEThresholdHB = _thresholdsHBphase1, | ||
recHitEThresholdHE = _thresholdsHEphase1, | ||
maxHcalRecHitSeverity = cms.int32(9), | ||
) | ||
|
||
egammaHBHERecHit_2023 = egammaHBHERecHit.clone( | ||
recHitEThresholdHB = _thresholdsHBphase1_2023 | ||
) | ||
|
||
from Configuration.Eras.Modifier_run3_egamma_2023_cff import run3_egamma_2023 | ||
run3_egamma_2023.toReplaceWith(egammaHBHERecHit,egammaHBHERecHit_2023) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be clearer to define the
Run3_2023
era as