-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.6.X] Ensure that egamma picks up 2023 HB thresholds for 12_6_X MC production #40756
Conversation
A new Pull Request was created by @swagata87 (Swagata Mukherjee) for CMSSW_12_6_X. It involves the following packages:
@perrotta, @rappoccio, @clacaputo, @cmsbuild, @mandrenguyen, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
from Configuration.Eras.Era_Run2_2018_cff import Run2_2018 | ||
from Configuration.Eras.Modifier_run3_common_cff import run3_common | ||
from Configuration.Eras.Modifier_run3_GEM_cff import run3_GEM | ||
from Configuration.Eras.Modifier_run3_HB_cff import run3_HB | ||
from Configuration.Eras.Modifier_run3_HFSL_cff import run3_HFSL | ||
from Configuration.Eras.Modifier_run2_GEM_2017_cff import run2_GEM_2017 | ||
from Configuration.Eras.Modifier_stage2L1Trigger_2021_cff import stage2L1Trigger_2021 | ||
from Configuration.Eras.Modifier_ctpps_2018_cff import ctpps_2018 | ||
from Configuration.Eras.Modifier_ctpps_2022_cff import ctpps_2022 | ||
from Configuration.ProcessModifiers.dd4hep_cff import dd4hep | ||
from Configuration.Eras.Modifier_run3_egamma_cff import run3_egamma | ||
from Configuration.Eras.Modifier_run2_egamma_2018_cff import run2_egamma_2018 | ||
from Configuration.Eras.Modifier_run3_RPC_cff import run3_RPC | ||
from Configuration.Eras.Modifier_run3_egamma_2023_cff import run3_egamma_2023 | ||
|
||
Run3_2023 = cms.ModifierChain(Run2_2018.copyAndExclude([run2_GEM_2017, ctpps_2018, run2_egamma_2018]), | ||
run3_common, run3_egamma, run3_egamma_2023, run3_GEM, run3_HB, run3_HFSL, stage2L1Trigger_2021, ctpps_2022, dd4hep, run3_RPC) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be clearer to define the Run3_2023
era as
from Configuration.Eras.Era_Run2_2018_cff import Run2_2018 | |
from Configuration.Eras.Modifier_run3_common_cff import run3_common | |
from Configuration.Eras.Modifier_run3_GEM_cff import run3_GEM | |
from Configuration.Eras.Modifier_run3_HB_cff import run3_HB | |
from Configuration.Eras.Modifier_run3_HFSL_cff import run3_HFSL | |
from Configuration.Eras.Modifier_run2_GEM_2017_cff import run2_GEM_2017 | |
from Configuration.Eras.Modifier_stage2L1Trigger_2021_cff import stage2L1Trigger_2021 | |
from Configuration.Eras.Modifier_ctpps_2018_cff import ctpps_2018 | |
from Configuration.Eras.Modifier_ctpps_2022_cff import ctpps_2022 | |
from Configuration.ProcessModifiers.dd4hep_cff import dd4hep | |
from Configuration.Eras.Modifier_run3_egamma_cff import run3_egamma | |
from Configuration.Eras.Modifier_run2_egamma_2018_cff import run2_egamma_2018 | |
from Configuration.Eras.Modifier_run3_RPC_cff import run3_RPC | |
from Configuration.Eras.Modifier_run3_egamma_2023_cff import run3_egamma_2023 | |
Run3_2023 = cms.ModifierChain(Run2_2018.copyAndExclude([run2_GEM_2017, ctpps_2018, run2_egamma_2018]), | |
run3_common, run3_egamma, run3_egamma_2023, run3_GEM, run3_HB, run3_HFSL, stage2L1Trigger_2021, ctpps_2022, dd4hep, run3_RPC) | |
from Configuration.Eras.Era_Run3_cff import Run3 | |
from Configuration.Eras.Modifier_run3_egamma_2023_cff import run3_egamma_2023 | |
Run3_2023 = cms.ModifierChain(Run3, run3_egamma_2023) |
Pull request #40756 was updated. @perrotta, @rappoccio, @clacaputo, @cmsbuild, @mandrenguyen, @fabiocos, @davidlange6 can you please check and sign again. |
type egamma |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-48f63a/30612/summary.html Comparison SummarySummary:
|
+1 |
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will be automatically merged. |
PR description:
This is to ensure that egamma reco picks up updated HB recHit thresholds for 12_6_X MC production.
A new Era called
Run3_2023
is introduced:Configuration/Eras/python/Era_Run3_2023_cff.py
.At the time of opening this PR,
Era_Run3_2023_cff.py
andEra_Run3_cff.py
are basically same, the only notable difference is thatrun3_egamma_2023
is included in ModifierChain ofRun3_2023
.PR validation:
After doing this:
cmsDriver.py step3 -s RAW2DIGI,L1Reco,RECO,RECOSIM,PAT,NANO,VALIDATION:@standardValidation+@miniAODValidation,DQM:@standardDQM+@ExtraHLT+@miniAODDQM+@nanoAODDQM --conditions auto:phase1_2023_realistic --datatier GEN-SIM-RECO,MINIAODSIM,NANOAODSIM,DQMIO -n 10 --eventcontent RECOSIM,MINIAODSIM,NANOEDMAODSIM,DQM --geometry DB:Extended --era Run3_2023 --filein file:step2.root --fileout file:step3.root --customise RecoParticleFlow/PFClusterProducer/particleFlow_HB2023.customiseHB2023 --no_exec
obtained
step3_RAW2DIGI_L1Reco_RECO_RECOSIM_PAT_NANO_VALIDATION_DQM.py
.Then,
edmConfigDump step3_RAW2DIGI_L1Reco_RECO_RECOSIM_PAT_NANO_VALIDATION_DQM.py > dump_1.py
;Checked by doing
grep recHitEThresholdHB dump_1.py
that correct HB thresholds were picked up everywhere; i.e.recHitEThresholdHB = cms.vdouble(0.4, 0.3, 0.3, 0.3),
indump_1.py
.Checked that
step3_RAW2DIGI_L1Reco_RECO_RECOSIM_PAT_NANO_VALIDATION_DQM.py
runs fine on a proper input root file.Note that
--customise RecoParticleFlow/PFClusterProducer/particleFlow_HB2023.customiseHB2023
is availablevia #40689
There is no corresponding PR for master branch, as discussed with PPD. For now, this change is needed only for 12_6_X MC production. Studies based on the upcoming 12_6_X MC would tell us if these changes need to be propagated to the 2023 data-taking release (13_X) or not.