[12_4_X] add DT and CSC rechits to AOD content

[kakwok]

PR description:

Backport of #40251 for 2022 data re-processing and signal MC production.

This PR adds CSC/DT rechits to the AOD datatier, which are the essential inputs for multiple searches of LLP decaying in the muon system and evaluating related trigger performances

PR validation:

Backport of #40251

[cmsbuild]

A new Pull Request was created by @kakwok for CMSSW_12_4_X.

It involves the following packages:

• RecoLocalMuon/Configuration (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@bellan, @abbiendi, @battibass, @jhgoh, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[clacaputo]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-50350d/30464/summary.html
COMMIT: 9579e85
CMSSW: CMSSW_12_4_X_2023-02-07-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40687/30464/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 15 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3766083
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3766047
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 167 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[clacaputo]

Hi @kakwok , what is the reason for this backport?
Consider that for 2022 MC it could be possible to create a new chain in MccM for some samples; instead, for 2022 data it's not possible, the workflows are already in place.

FYI @cms-sw/pdmv-l2

[sixie]

@clacaputo : The purpose for the backport is to be able to use it for additional 2022 MC production. Our signal production has not started yet, so this is an opportunity to have the DT and CSC hits available in AOD for the new signal MC.

[clacaputo]

Hi @smuzaffar, the bot reports ROOTFileChecks: Some differences in event products or their sizes found, is there a list of the differences somewhere in summary.html?

[cmorgoth]

Since this PR adds CSC/DT rechits to the AOD datatier we expect to be some differences in the event size.
Considering this is urgent for the MC production for early Run3 analysis can we please proceed?

[clacaputo]

enable profiling

[clacaputo]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-50350d/30743/summary.html
COMMIT: 9579e85
CMSSW: CMSSW_12_4_X_2023-02-19-0000/el8_amd64_gcc10
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40687/30743/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3766083
• DQMHistoTests: Total failures: 19
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3766041
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 212 log files, 167 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[clacaputo]

+reconstruction

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

hold

• As it was suggested at the ORP meeting of Feb 21, this can be implemented as a customization in those few productions that need it in the closed 12_4_X cycle

[cmsbuild]

Pull request has been put on hold by @perrotta
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[sixie]

@perrotta : can you explain what the suggestion is? We would like this modification for ALL MC productions for 2022. not just "a few". It should be the default.

[clacaputo]

@clacaputo : The purpose for the backport is to be able to use it for additional 2022 MC production. Our signal production has not started yet, so this is an opportunity to have the DT and CSC hits available in AOD for the new signal MC.

@sixie Here you claim that you need this PR only for the new "signal MC", not for all the MC productions. Based on the info you provided, we decided to propose you to add the new collections through a cmsDriver customization

[perrotta]

assign ppd

[cmsbuild]

New categories assigned: ppd

@jordan-martins,@malbouis you have been requested to review this Pull request/Issue and eventually sign? Thanks

[tvami]

Requested PdmV to make new chains in https://its.cern.ch/jira/projects/PDMVMCPROD/issues/PDMVMCPROD-105
After chains are done, there is no need for this PR, we can just make samples specifying the chains that will save the muon hits.

[tvami]

@cmsbuild , please close

• signal samples are being produced with this content, w/o the need of this PR