PPD category

[jordan-martins]

Dear all,

We would like to request the creation of a PPD category in here. Initially, we had thought to pick up the PPD coordinator e-group information, but after an exchange with @smuzaffar, this seems not possible.

In case release managers think that the category makes sense, please adjust PPD accordingly.

Thanks for your consideration,
Jordan for PPD

FYI @dpiparo @perrotta @rappoccio @malbouis

[cmsbuild]

A new Issue was created by @jordan-martins Jordan Martins.

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[makortel]

Just to clarify, to what exactly do you expect the PPD category would be used for?

1. To assign issues and/or pull requests case-by-case for PPD L1s to review?
2. To automatically assign pull request (by CMSSW packages as defined in categories_map.py) for PPD L1s to review?
3. To label issues and/or pull requests case-by-case so that it is easy filter some PPD-related issues and/or PRs?
4. To automatically label pull requests (by CMSSW packages as defined in categories_map.py) so that is is easy to filter all PPD-related PRs?
5. To tag with @cms-sw/ppd-l1 in issues and PRs?
6. Something else?

[jordan-martins]

Hi @makortel,

bullet 1: yes
bullet 2: no
bullet 3: yes
bullet 4: no
bullet 5: yes

You covered all the cases I could and couldn't think of. :)

Thanks,
Jordan for PPD

[makortel]

Thanks @jordan-martins. Then, in addition of adding a ppd category to categories.py, we'd need to add ppd-l1 team in https://github.com/orgs/cms-sw/teams (and probably include its members as part of the all-l2 even if they technically are L1s?).

[davidlange6]

I get the point of having teams – whats an example use case of a category in this case? (having all corresponding l2 groups already there) From: Matti Kortelainen ***@***.***> Date: Wednesday, May 31, 2023 at 5:37 PM To: cms-sw/cmssw ***@***.***> Cc: Subscribed ***@***.***> Subject: Re: [cms-sw/cmssw] PPD category (Issue #41821) Thanks @jordan-martins<https://github.com/jordan-martins>. Then, in addition of adding a ppd category to categories.py<https://github.com/cms-sw/cms-bot/blob/master/categories.py>, we'd need to add ppd-l1 team in https://github.com/orgs/cms-sw/teams (and probably include its members as part of the all-l2 even if they technically are L1s?). — Reply to this email directly, view it on GitHub<#41821 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ4TWO4AAIE4DZJXGZLXI5QSHANCNFSM6AAAAAAYVESPIY>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[jordan-martins]

Hi @makortel,
Including the team members in all-l2 is fine.
Thanks, and sorry for the delay,
Jordan

[makortel]

@jordan-martins Could you comment @davidlange6's question (#41821 (comment))?

[jordan-martins]

Hi @davidlange6,

In short, we would like to be able to be tagged in PRs when decisions are needed and also to sign off CORE PPD areas in case one of our groups misses. That's all... From my side, I understood that was covered here. Would this be what you were asking?

Thanks,
Jordan

[davidlange6]

Creating a ppd signoff category isn't going to accomplish either of those goals. I believe you would want a team so that it's easy to tag you and to be added to the existing dqm,alca, pdmv, etc categories. Adding a ppd category and assigning it packages would mean you should sign all such pull requests

[jordan-martins]

Thanks, @davidlange6! I see your point, and we do not want to have the obligation of signing off packages. Sorry for the confusion. Can we proceed as you suggest, please?
Best,
Jordan

[perrotta]

I've added a new ppd team:
https://github.com/orgs/cms-sw/teams/ppd-l2/members

Please don't be upset if you are considered only "L2" in github teams: I think this is the rule... ;-)

For the moment I added only @jordan-martins and @malbouis , because I don't remember the github nick of Kaori: feel free to add Kaori yourself to the team. Apparently I am able to tag you with @cms-sw/ppd-l2

Categories are also updated in https://github.com/cms-sw/cms-bot/blob/master/categories.py

Just to check that everything works, I assigned PR #40687 to ppd: it is a PR we don't plan to merge, and therefore your signature will not really be needed there. But you can assign yourself any other PR that you think you should

[perrotta]

For the "all-l2" category, should I add the names explicitely in https://github.com/orgs/cms-sw/teams/all-l2, or is there a way to include the categories in it, and the names will get automatically updated with them?

[makortel]

Is there still something to be done?

[perrotta]

Is there still something to be done?

Well, I was waiting for an answer to my question in #41821 (comment)
Since I don't know exactly what the "all-l2" category is intended for, if @cms-sw/ppd-l2 is not interested in being included there we can even close this issue, then

[makortel]

I'd guess people need to be added explicitly in all-l2. I don't think we have really used it for anything so far, but for consistency I'd add ppd-l2 members there.

I started to wonder though if we have any automation for propagating changes from the categories.py to the GitHub teams (not strictly relevant for this issue, but how the GitHub teams should be updated in general). @smuzaffar @cms-sw/externals-l2 ?

[aandvalenzuela]

Hello @makortel, @perrotta,
I don't think there is any synchronization in place from the categories.py script to the GitHub teams. Nevertheless, I think it should be relatively easy to set up since GitHub teams can be updated via the GitHub API. If you agree, I can open an issue in cms-bot and set up a Jenkins job for that purpose.

Many thanks!
Andrea

[makortel]

Thanks @aandvalenzuela! I think an automated update for the GitHub teams would be useful, but only for those teams that have a corresponding category (i.e. not for the ppd-l2 team, I'm not sure if there are others). The all-l2 team would also need a special treatment.

[smuzaffar]

There is a jenkins job which automate the teams. All-l2 is automatically generated using all the memebers of l2 categories.
All rhe cms-sw teams should be managed and contril by bot. For special teams we have a separate mapping in cms-bot

[aandvalenzuela]

Oh, I was not aware of this job, my bad!