Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.5.X] fix ClusterStorer::ClusterHitRecord<T>::rekey for Phase2TrackerRecHit1D #40559

Merged
merged 1 commit into from
Jan 21, 2023
+7 −7
Merged

[12.5.X] fix ClusterStorer::ClusterHitRecord<T>::rekey for Phase2TrackerRecHit1D #40559

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions CommonTools/RecoAlgos/src/ClusterStorer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,22 +181,22 @@ namespace helper {
}

// -------------------------------------------------------------
// Specific rekey for class template ClusterRefType = VectorHit::ClusterRef,
// RecHitType is not used.
// Specific rekey for class template ClusterRefType = Phase2TrackerRecHit1D::ClusterRef
template <>
template <typename RecHitType> // or template<> to specialise also here?
void ClusterStorer::ClusterHitRecord<VectorHit::ClusterRef>::rekey(const VectorHit::ClusterRef &newRef) {
template <typename RecHitType>
void ClusterStorer::ClusterHitRecord<Phase2TrackerRecHit1D::ClusterRef>::rekey(
const Phase2TrackerRecHit1D::ClusterRef &newRef) {
TrackingRecHit &genericHit = (*hits_)[index_];
const std::type_info &hit_type = typeid(genericHit);

OmniClusterRef *cluRef = nullptr;
if (typeid(VectorHit) == hit_type) {
if (typeid(Phase2TrackerRecHit1D) == hit_type) {
cluRef = &static_cast<Phase2TrackerRecHit1D &>(genericHit).omniCluster();
} else if (typeid(VectorHit) == hit_type) {
VectorHit &vHit = static_cast<VectorHit &>(genericHit);
// FIXME: this essentially uses a hack
// https://github.com/cms-sw/cmssw/blob/master/DataFormats/TrackerCommon/interface/TrackerTopology.h#L291
cluRef = (SiStripDetId(detid_).stereo() ? &vHit.upperClusterRef() : &vHit.lowerClusterRef());
} else {
return;
}

assert(cluRef != nullptr); // to catch missing RecHit types
Expand Down